feat(702): support for custom uploads and backup location by Sim-sat · Pull Request #1179 · CodeWithCJ/SparkyFitness

Sim-sat · 2026-04-22T06:17:11Z

Description

What problem does this PR solve?
Upload/backup folder was hardcoded which is fine for docker, but not for standalone use.

How did you implement the solution?
Added envrionment variables to allow setting custom directories.

Linked Issue: Closes #702

How to Test

Set variables
Verify the upload and backup still work

PR Type

Issue (bug fix)
New Feature
Refactor
Documentation

Checklist

All PRs:

[MANDATORY - ALL] Integrity & License: I certify this is my own work, free of malicious code, and I agree to the License terms.

New features only:

[MANDATORY for new feature] Alignment: I have raised a GitHub issue and it was reviewed/approved by maintainers or it was approved on Discord.

Frontend changes (SparkyFitnessFrontend/ or src/):

[MANDATORY for Frontend changes] Quality: I have run pnpm run validate and it passes.
[MANDATORY for Frontend changes] Translations: I have only updated the English (en) translation file.

Backend changes (SparkyFitnessServer/):

[MANDATORY for Backend changes] Code Quality: I have run typecheck, lint, and tests. New files use TypeScript, new endpoints have Zod schemas, and new endpoints include tests.
[MANDATORY for Backend changes] Database Security: I have updated rls_policies.sql for any new user-specific tables.

UI changes (components, screens, pages):

[MANDATORY for UI changes] Screenshots: I have attached Before/After screenshots below.

gemini-code-assist

Code Review

This pull request introduces environment variables to allow custom paths for uploads and backups, and adds a PostgreSQL client to the development Dockerfile. Review feedback identifies a bug in the image serving logic where absolute paths are incorrectly handled, an incorrect relative path for the default uploads directory in the image downloader utility, and significant code duplication in how environment variables are resolved across the codebase.

Sim-sat · 2026-04-22T16:10:30Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces configurable environment variables for custom upload and backup directories across several server components and adds the PostgreSQL client to the development Dockerfile. Feedback identifies a path resolution bug in the image downloader utility and suggests centralizing the directory configuration logic to improve maintainability and prevent duplication errors.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/codewithcj/sparkyfitness-frontend](https://github.com/CodeWithCJ/SparkyFitness) | patch | `v0.16.5.8` → `v0.16.5.9` | | [ghcr.io/codewithcj/sparkyfitness-server](https://github.com/CodeWithCJ/SparkyFitness) | patch | `v0.16.5.8` → `v0.16.5.9` | --- ### Release Notes <details> <summary>CodeWithCJ/SparkyFitness (ghcr.io/codewithcj/sparkyfitness-frontend)</summary> ### [`v0.16.5.9`](https://github.com/CodeWithCJ/SparkyFitness/releases/tag/v0.16.5.9) [Compare Source](CodeWithCJ/SparkyFitness@v0.16.5.8...v0.16.5.9) ⚠️ Backup before upgrading. If you don’t see the latest updates, please refresh or clear your browser cache. ⚠️ Android App – Google Play closed testing URL has changed. Refer to the updated link in the Wiki. ⚠️ Though you don't need to immediately upgrade, in the upcoming months the Postgres upgrade will be mandated. Have caution. Below guide might have flaws. Research yourself before performing the upgrade. <https://codewithcj.github.io/SparkyFitness/install/postgres-upgrade> 💙 Support SparkyFitness Support development if you find SparkyFitness useful — Approximately $250 in remaining project expenses.  ##### What's Changed ##### Features - feat(994): goal tracking reports by [@Sim-sat](https://github.com/Sim-sat) in [#1206](CodeWithCJ/SparkyFitness#1206) - feat: imroved reports for nutrition data by [@Sim-sat](https://github.com/Sim-sat) in [#1212](CodeWithCJ/SparkyFitness#1212) ##### Fixes - fix: auto labeling for mistakenly adds bug label by [@Sim-sat](https://github.com/Sim-sat) in [#1207](CodeWithCJ/SparkyFitness#1207) - fix(1211): unused api endpoints by [@Sim-sat](https://github.com/Sim-sat) in [#1213](CodeWithCJ/SparkyFitness#1213) ##### Other Changes - App Workout Timer by [@apedley](https://github.com/apedley) in [#1143](CodeWithCJ/SparkyFitness#1143) - feat(781): meal calorie distribution for custom meals by [@Sim-sat](https://github.com/Sim-sat) in [#1145](CodeWithCJ/SparkyFitness#1145) - fix: food unit conversion behavior for compatible and incompatible variants by [@BryceKrispiess](https://github.com/BryceKrispiess) in [#1148](CodeWithCJ/SparkyFitness#1148) - feat(566): reorder nutrients by [@Sim-sat](https://github.com/Sim-sat) in [#1149](CodeWithCJ/SparkyFitness#1149) - feat(839): add averages to reports by [@Sim-sat](https://github.com/Sim-sat) in [#1150](CodeWithCJ/SparkyFitness#1150) - fix(1151, 1045): wger serch doesn't respect language and endpoints are deprecated by [@Sim-sat](https://github.com/Sim-sat) in [#1152](CodeWithCJ/SparkyFitness#1152) - Smoother App Animations by [@BryceKrispiess](https://github.com/BryceKrispiess) in [#1155](CodeWithCJ/SparkyFitness#1155) - feat: refresh dashboard and other tabs after sync automatically by [@BryceKrispiess](https://github.com/BryceKrispiess) in [#1159](CodeWithCJ/SparkyFitness#1159) - Feat: Additional app haptics by [@BryceKrispiess](https://github.com/BryceKrispiess) in [#1161](CodeWithCJ/SparkyFitness#1161) - fix(1156): secret file not working anymore by [@Sim-sat](https://github.com/Sim-sat) in [#1163](CodeWithCJ/SparkyFitness#1163) - iOS Home Screen Widget by [@apedley](https://github.com/apedley) in [#1157](CodeWithCJ/SparkyFitness#1157) - feat: improve ui for exercises and support cardio and isometric types by [@Sim-sat](https://github.com/Sim-sat) in [#1164](CodeWithCJ/SparkyFitness#1164) - fix(1158): garmin activity sync fail by [@Sim-sat](https://github.com/Sim-sat) in [#1166](CodeWithCJ/SparkyFitness#1166) - fix(1165): execute preflight checks before server startup by [@Sim-sat](https://github.com/Sim-sat) in [#1167](CodeWithCJ/SparkyFitness#1167) - feat: app logs rework and expansion by [@apedley](https://github.com/apedley) in [#1168](CodeWithCJ/SparkyFitness#1168) - fix: exercises add from external and public workout presets by [@apedley](https://github.com/apedley) in [#1171](CodeWithCJ/SparkyFitness#1171) - fix(1169): focus for input unit keeps resetting while typing by [@Sim-sat](https://github.com/Sim-sat) in [#1172](CodeWithCJ/SparkyFitness#1172) - fix(1139): filter active calories from workout reports by [@apedley](https://github.com/apedley) in [#1175](CodeWithCJ/SparkyFitness#1175) - feat(1080): add bundled postgresql resources to helm chart by [@Sim-sat](https://github.com/Sim-sat) in [#1178](CodeWithCJ/SparkyFitness#1178) - feat(702): support for custom uploads and backup location by [@Sim-sat](https://github.com/Sim-sat) in [#1179](CodeWithCJ/SparkyFitness#1179) - feat: improved ui for exercise entries by [@Sim-sat](https://github.com/Sim-sat) in [#1181](CodeWithCJ/SparkyFitness#1181) - feat(1044): equivalent variants for foods by [@Sim-sat](https://github.com/Sim-sat) in [#1182](CodeWithCJ/SparkyFitness#1182) - feat: app: change workouts tab to library by [@apedley](https://github.com/apedley) in [#1183](CodeWithCJ/SparkyFitness#1183) - fix: add sheet spacing after modal sheet by [@apedley](https://github.com/apedley) in [#1189](CodeWithCJ/SparkyFitness#1189) - fix(1180): recalc sleep after merge by [@apedley](https://github.com/apedley) in [#1190](CodeWithCJ/SparkyFitness#1190) - App meal creation support by [@BryceKrispiess](https://github.com/BryceKrispiess) in [#1195](CodeWithCJ/SparkyFitness#1195) - Fix(1187): misleading placement of height input by [@Sim-sat](https://github.com/Sim-sat) in [#1191](CodeWithCJ/SparkyFitness#1191) - fix: backup doesn't work with 18.3 due to old image version by [@Sim-sat](https://github.com/Sim-sat) in [#1192](CodeWithCJ/SparkyFitness#1192) - feat: standardize tables to allow universal filtering, pagination, bulk actions and match the UI by [@Sim-sat](https://github.com/Sim-sat) in [#1196](CodeWithCJ/SparkyFitness#1196) - App Android Widget by [@apedley](https://github.com/apedley) in [#1198](CodeWithCJ/SparkyFitness#1198) - App Meal Nutrition + UI Tweaks by [@apedley](https://github.com/apedley) in [#1194](CodeWithCJ/SparkyFitness#1194) - feat: improve changelog creation and auto label pr's by [@Sim-sat](https://github.com/Sim-sat) in [#1146](CodeWithCJ/SparkyFitness#1146) - feat: mobile nutrient display and entry details by [@apedley](https://github.com/apedley) in [#1205](CodeWithCJ/SparkyFitness#1205) - feat: saving selected date to search parameters and improve calendar UI by [@Sim-sat](https://github.com/Sim-sat) in [#1209](CodeWithCJ/SparkyFitness#1209) - fix: pr validation workflow duplicate variable by [@Sim-sat](https://github.com/Sim-sat) in [#1210](CodeWithCJ/SparkyFitness#1210) **Full Changelog**: <CodeWithCJ/SparkyFitness@v0.16.5.8...v0.16.5.9> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/315

gemini-code-assist Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread SparkyFitnessServer/SparkyFitnessServer.ts Outdated

Comment thread SparkyFitnessServer/utils/imageDownloader.ts Outdated

Comment thread SparkyFitnessServer/SparkyFitnessServer.ts

Sim-sat force-pushed the feat-702 branch 2 times, most recently from 25b6ed3 to eca1568 Compare April 22, 2026 16:01

feat(702): support for custom uploads and backup location

a3af75e

Sim-sat force-pushed the feat-702 branch from eca1568 to a3af75e Compare April 22, 2026 16:10

gemini-code-assist Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread SparkyFitnessServer/utils/imageDownloader.ts Outdated

Comment thread SparkyFitnessServer/SparkyFitnessServer.ts

Update SparkyFitnessServer/utils/imageDownloader.ts

26aec51

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

CodeWithCJ approved these changes Apr 23, 2026

View reviewed changes

CodeWithCJ merged commit 373b0e1 into CodeWithCJ:main Apr 23, 2026
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(702): support for custom uploads and backup location#1179

feat(702): support for custom uploads and backup location#1179
CodeWithCJ merged 2 commits intoCodeWithCJ:mainfrom
Sim-sat:feat-702

Sim-sat commented Apr 22, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sim-sat commented Apr 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Sim-sat commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How to Test

PR Type

Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sim-sat commented Apr 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sim-sat commented Apr 22, 2026 •

edited

Loading