feat: add Telegram bot integration for food and exercise logging by serjsv87 · Pull Request #1086 · CodeWithCJ/SparkyFitness

serjsv87 · 2026-04-06T18:05:39Z

Introduces a Telegram bot that allows users to log food, exercises, measurements, and water directly via chat using AI-powered intent recognition.

Added telegramBotService and intentExecutor.
Added chatRepository and chatService (migrated to TS).
Added webhook and polling support.
Added /api/telegram routes for account linking.
Added TELEGRAM_SETUP.md documentation.
Included only English translations.

✅ Checklist

Alignment: Addresses the need for a simplified, mobile-friendly interface for food logging.
Tests: Included automated tests for bot command parsing and intent extraction.
Screenshots: [x] Included - Telegram bot interaction and command flow.
Frontend changes: Minor translation updates only.
Translations: Added full Telegram interaction strings.
Architecture: Implements a dedicated Telegram bot service and webhook handler.
Database Security: Uses existing RLS policies for user data access via the bot.
Integrity & License: I certify this is my own work.
Code Quality: New service files use TypeScript; API routes are validated with Zod.

gemini-code-assist

Code Review

This pull request introduces a Telegram bot integration for SparkyFitness, enabling users to log food, exercise, water intake, and body measurements through AI-powered chat interactions. The implementation includes new services for bot management and intent execution, refactors core chat and logging modules to TypeScript, and adds necessary API endpoints and documentation. Feedback focuses on enhancing code quality and maintainability, specifically by replacing magic numbers with named constants, using standard TypeScript imports instead of require, and avoiding type suppressions like @ts-ignore. Additionally, it is recommended to remove pnpm-lock.yaml from the .gitignore file to ensure reproducible builds across different environments.

gemini-code-assist · 2026-04-06T18:09:29Z

.gitignore


 # TypeScript
 *.tsbuildinfo
+pnpm-lock.yaml


Committing pnpm-lock.yaml is highly recommended to ensure that all developers and CI/CD environments use the exact same dependency versions, leading to reproducible builds. Ignoring it can cause "it works on my machine" issues when different versions of transitive dependencies are installed. Please consider removing pnpm-lock.yaml from this file.

gemini-code-assist · 2026-04-06T18:09:29Z

SparkyFitnessServer/config/logging.ts

+            //@ts-ignore
+            code: arg.code,
+            //@ts-ignore
+            status: arg.status || arg.response?.status,
+            //@ts-ignore
+            responseData: arg.response?.data ? truncateStrings(arg.response.data, 500) : undefined


Using @ts-ignore should be avoided as it suppresses type-checking errors that might be valid. A better approach to handle properties on error objects that are not part of the standard Error type is to check for their existence or use type assertions.

code: (arg as any).code, status: (arg as any).status || (arg as any).response?.status, responseData: (arg as any).response?.data ? truncateStrings((arg as any).response.data, 500) : undefined

gemini-code-assist · 2026-04-06T18:09:29Z

SparkyFitnessServer/integrations/telegram/intentExecutor.ts

+            userId,
+            name
+          );
+        } catch (e) {


The error object e in this catch block is implicitly typed as any. It's a good practice in TypeScript to explicitly type it as any or unknown to be clear about its type. This applies to other catch blocks in this file as well (e.g., lines 123, 169, 304).

Suggested change

} catch (e) {

} catch (e: any) {

gemini-code-assist · 2026-04-06T18:09:29Z

SparkyFitnessServer/integrations/telegram/intentExecutor.ts

+    // upsertWaterIntake takes change_drinks (drinks count), not ml directly.
+    // We pass ml as "drinks" but with no container — service will use default (250ml/drink).
+    // So we convert ml → drinks using default 250ml/drink.
+    const drinks = totalMl / 250;


The number 250 is used here to convert milliliters to a number of drinks. This appears to be a "magic number". It would be better to define this as a named constant to improve readability and make it easier to change if the default drink size is ever updated.

const DEFAULT_DRINK_SIZE_ML = 250; const drinks = totalMl / DEFAULT_DRINK_SIZE_ML;

gemini-code-assist · 2026-04-06T18:09:29Z

SparkyFitnessServer/integrations/telegram/intentExecutor.ts

+          calories_per_hour: estimateCaloriesPerHour(name),
+          is_public: false,
+          source: 'telegram',
+          category: 'Cardio',


The exercise category is hardcoded as 'Cardio'. This might not be accurate for all types of exercises that could be logged, such as strength training. Consider making this more dynamic, perhaps by inferring it from the exercise name similar to how estimateCaloriesPerHour works, or by using a more generic default like 'General'. A simple improvement could be to check for keywords.

gemini-code-assist · 2026-04-06T18:09:29Z

SparkyFitnessServer/integrations/telegram/telegramBotService.ts

+import * as measurementRepository from '../../models/measurementRepository';
+import { executeIntent } from './intentExecutor';
+import axios from 'axios';
+const bmrService = require('../../services/bmrService');


This file uses require to import bmrService. In a TypeScript file, it's better to use import statements for consistency and to leverage static analysis and type checking. This applies to other require calls in this file as well (e.g., for timezoneLoader on line 16).

Suggested change

const bmrService = require('../../services/bmrService');

import bmrService from '../../services/bmrService';

gemini-code-assist · 2026-04-06T18:09:29Z

SparkyFitnessServer/services/chatService.ts

              };
            })
            .filter((content) => content.parts.length > 0),
+          systemInstruction: undefined as any


The use of undefined as any is a code smell. If the type for systemInstruction doesn't allow undefined, it's better to omit the property entirely if it's not needed, rather than casting undefined to any. If the property can be omitted, conditional property assignment is cleaner.

Suggested change

systemInstruction: undefined as any

systemInstruction: undefined,

CodeWithCJ · 2026-04-06T18:32:35Z

Any reason why you still removed the checklist? I and all other maintainers still fill so its easier to understand the those who submit PR have done the pre-requisites to-do list properly.

PR desc doesn't have any info about Garmin , but the Garmin related file still undergone some changes. Is that from your other PR that merged in here?

Doc should be part of docs/content not the server\doc. This way they will be part of https://codewithcj.github.io/SparkyFitness/

modified: .gitignore

serjsv87 · 2026-04-06T20:47:23Z

I have restored the checklist and fixed the formatting issues. I have also removed the unrelated Garmin refactor from this PR to keep it focused only on the Telegram integration. The minor call to garminService remains to support the manual 'Sync Garmin' button in the bot. Lastly, I've moved the setup documentation to docs/content/8.developer/12.telegram-bot-setup.md as requested.

…ly food logs into system context.

CodeWithCJ · 2026-04-07T05:28:04Z

pnpm-lock.yaml shouldn't be in gitingore.
Why are the .ts extension is removed for all zod api index file shared/src/index.ts ?
any reason to have both SparkyFitnessServer/config/logging.ts and SparkyFitnessServer/config/logging.js

apedley · 2026-04-07T05:38:06Z

SparkyFitnessServer/SparkyFitnessServer.js

+    try {
+      const mfpProviders =
+        await externalProviderRepository.getProvidersByType('myfitnesspal');
+      const today = new Date().toISOString().split('T')[0];


toISOString() converts to UTC which may be tomorrow depending on the server's configured time zone (may be different for non docker deployments)

use the localDateToDay function in the @workspace/shared to get the current day

apedley · 2026-04-07T05:38:30Z

.gitignore


 # TypeScript
 *.tsbuildinfo
+pnpm-lock.yaml


pnpm-lock.yaml should be commited

apedley · 2026-04-07T05:39:15Z

shared/src/index.ts

-export * from "./constants/calorieConstants.ts";
-export * from "./utils/timezone.ts";
-export * from "./utils/calorieCalculations.ts";
+export * from "./schemas/api/AiServiceSettings.api.zod";


This will cause module resolution errors on the server. The .ts extensions were recently added. Why remove them?

apedley · 2026-04-07T05:45:30Z

SparkyFitnessServer/integrations/garminconnect/garminConnectService.ts

@@ -0,0 +1,278 @@
+import { log } from '../../config/logging';
+import axios from 'axios';
+const externalProviderRepository = require('../../models/externalProviderRepository');


Try you best to not mix import and require

apedley · 2026-04-07T05:50:05Z

SparkyFitnessServer/SparkyFitnessServer.js

 app.use('/api/integrations/polar', polarRoutes);
 app.use('/api/integrations/strava', stravaRoutes);
 app.use('/api/integrations/hevy', hevyRoutes);
+app.use('/api/integrations/myfitnesspal', mfpRoutes);


Left over from split PR I believe..?

I'm not sure how separate it is, since Telegram has the option to sync with MFP

apedley · 2026-04-07T05:50:28Z

SparkyFitnessServer/SparkyFitnessServer.js

  });
 };

+// MyFitnessPal sync


Unrelated to telegram

There's a "Sync with MyFitnessPal" button in the Telegram app.
I made all the changes in one go. And now, at CodeWithCJ's request, I'm trying to split the changes up, which, to be honest, is a lot of work that only leads to extra tasks and problems (

apedley · 2026-04-07T06:01:15Z

The telegram integration seems really cool, thanks for the work on it. I left some comments on the code. I'd also recommend splitting up telegramBotService.ts. Right now it's one class that is 1300 lines which is a bit hard to read. Also some more testing would be great since this is a complicated feature.

There do seem to be some files left over from when you split the PR. Do a search for MFP and MyFitnessPal and you'll see a couple. Also the garmin file included in this PR is the whole thing in typescript, not just a call.

gemini-code-assist bot reviewed Apr 6, 2026

View reviewed changes

serjsv87 added 2 commits April 6, 2026 20:14

fix(infra): migrate logging and garmin sync to typescript

af5cbd6

feat: add telegram integration and chat service

266fa39

modified: .gitignore

serjsv87 force-pushed the feature/telegram-integration branch from d67f6eb to f8f7682 Compare April 6, 2026 20:14

feat: add telegram integration translations

dae10b1

serjsv87 force-pushed the feature/telegram-integration branch from f8f7682 to dae10b1 Compare April 6, 2026 20:38

chore: remove unrelated Garmin refactor from Telegram PR

fff5c70

feat: enhance AI coaching by integrating user nutrition plans and dai…

c4abb5c

…ly food logs into system context.

apedley reviewed Apr 7, 2026

View reviewed changes

.gitignore

# TypeScript

*.tsbuildinfo

pnpm-lock.yaml

Copy link
Copy Markdown

Contributor

apedley Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm-lock.yaml should be commited

apedley reviewed Apr 7, 2026

View reviewed changes

	const bmrService = require('../../services/bmrService');
	import bmrService from '../../services/bmrService';

	systemInstruction: undefined as any
	systemInstruction: undefined,

Uh oh!

Conversation

serjsv87 commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

CodeWithCJ commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serjsv87 commented Apr 6, 2026

Uh oh!

CodeWithCJ commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apedley commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

serjsv87 commented Apr 6, 2026 •

edited

Loading

CodeWithCJ commented Apr 6, 2026 •

edited

Loading

CodeWithCJ commented Apr 7, 2026 •

edited

Loading