Skip to content

fix/add provider version constraint#37

Closed
brandon-bennett-cf wants to merge 2 commits intomainfrom
fix/add-provider-version-constraint
Closed

fix/add provider version constraint#37
brandon-bennett-cf wants to merge 2 commits intomainfrom
fix/add-provider-version-constraint

Conversation

@brandon-bennett-cf
Copy link
Copy Markdown

@brandon-bennett-cf brandon-bennett-cf commented Oct 9, 2025

Pull Request Checklist

Take your time to read through these, don't just click through them. Only check the boxes if they apply.

Admin

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ❇️ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Required: I have tested the proposed changes to code (i.e. packer build, terraform apply), and they are working.
  • Required: All GitHub Actions ran successfully. If they didn't, I left a note in the description to address this.
  • Optional: I have already applied/deployed the changes in my environment.

Please check where this code has been tested

  • Locally
  • Customer Environment
  • Coalfire Sandbox Environment (AWS GovCloud, Azure Gov, GCP, etc.)

Documentation

  • Optional, recommended: I have updated README.md.
  • Optional, recommended: I have updated documentation in Confluence/Organization's relevant Wiki.
  • Optional, recommended: I left comments in-line in the code to help others understand the changes.

Tagging / Assigning

  • Required: I have tagged a Reviewer(s).
  • Required: I have tagged an Assignee(s).
  • Optional: I have tagged relevant stakeholders in a Comment.

@brandon-bennett-cf brandon-bennett-cf self-assigned this Oct 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

Terraform validation output:

╷

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

@brandon-bennett-cf @claude
fix: add minimum azurerm provider version constraint
e40924b 
The module uses storage_account_id attribute in azurerm_storage_container
and azurerm_storage_share resources, which was introduced in provider
version 4.9.0. Added version constraint to ensure compatibility.

Uses ~> 4.9 to allow patch and minor updates within the 4.x series
while preventing breaking changes from version 5.0.

BREAKING CHANGE: This module now requires azurerm provider ~> 4.9

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@brandon-bennett-cf brandon-bennett-cf force-pushed the fix/add-provider-version-constraint branch from 27fa9ef to e40924b Compare October 9, 2025 19:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kodyinthecloud kodyinthecloud Awaiting requested review from kodyinthecloud

@douglas-f douglas-f Awaiting requested review from douglas-f

@ls-cf ls-cf Awaiting requested review from ls-cf

Assignees

@brandon-bennett-cf brandon-bennett-cf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@brandon-bennett-cf