Skip to content

Migrating from Deprecated Attribute#31

Merged
douglas-f merged 1 commit intomainfrom
attribute_updates
Mar 19, 2025
Merged

Migrating from Deprecated Attribute#31
douglas-f merged 1 commit intomainfrom
attribute_updates

Conversation

@hunter-capestany-cf
Copy link
Copy Markdown
Contributor

Pull Request Checklist

Take your time to read through these, don't just click through them. Only check the boxes if they apply.

Admin

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ❇️ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Required: I have tested the proposed changes to code (i.e. packer build, terraform apply), and they are working.
  • Required: All GitHub Actions ran successfully. If they didn't, I left a note in the description to address this.
  • Optional: I have already applied/deployed the changes in my environment.

Please check where this code has been tested

  • Locally
  • Customer Environment
  • Coalfire Sandbox Environment (AWS GovCloud, Azure Gov, GCP, etc.)

Documentation

  • Optional, recommended: I have updated README.md.
  • Optional, recommended: I have updated documentation in Confluence/Organization's relevant Wiki.
  • Optional, recommended: I left comments in-line in the code to help others understand the changes.

Tagging / Assigning

  • Required: I have tagged a Reviewer(s).
  • Required: I have tagged an Assignee(s).
  • Optional: I have tagged relevant stakeholders in a Comment.

@github-actions
Copy link
Copy Markdown
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/container.tf CKV2_AZURE_21 Ensure Storage logging is enabled for Blob service for read requests azurerm_storage_container.main FAILED

Please review the above report. ⚠️

@douglas-f douglas-f merged commit ba8f5dc into main Mar 19, 2025
4 checks passed
@douglas-f douglas-f deleted the attribute_updates branch March 19, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The storage_account_name property is deprecated in favor of storage_account_id for the azurerm_storage_container and azurerm_storage_share resources

2 participants