Changes logger statement to print statement Issue #558#559
Merged
KevinShuman merged 1 commit intoCloud-Drift:mainfrom May 23, 2025
Merged
Changes logger statement to print statement Issue #558#559KevinShuman merged 1 commit intoCloud-Drift:mainfrom
KevinShuman merged 1 commit intoCloud-Drift:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes a logger debug message to a print statement in the gdp1h adapter to print the temporary directory.
- Changed _logger.debug call to print to display URL and temporary directory information
- The modification ensures that the temporary directory is printed directly to stdout
Comments suppressed due to low confidence (1)
clouddrift/adapters/gdp/gdp1h.py:83
- Using a print statement bypasses the structured logging system which may affect production diagnostics; ensure that this change aligns with the overall logging strategy for the application.
print(f"Downloading GDP hourly data from ({url}) to ({tmp_path})")
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Member
|
Looks like it's doing what it needs to do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address the want to have a print statement in the gdp1h adapter that prints the temporary directory.