Conversation
|
What |
|
The tests that failed in my case were re-run and passed after regenerating my local andro and glad datasets |
|
@philippemiron this seems to run in VS Code for me, see screenshot. What is this setting doing?
|
|
It just specify the folders of the tests (it's running
|
It is! It has many advantages. Would be easier to zoom to talk about it if you want more info. It's from the same people at Astral that built |
|
This looks good to me. Not sure wht the Lint/mypy test is failing? |
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes test file naming to the *_test.py pattern and aligns code/tests with the change, while also broadening type support.
- Update test filename globs in CONTRIBUTING.md
- Adjust existing tests to match new naming and suppress a type-checker warning
- Enhance
unpacktype hints to accept bothnp.ndarrayandxarray.DataArray
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/plotting_test.py | Suppress type checker warning on cartopy.crs import with # type: ignore |
| tests/kinematics_test.py | Convert boolean arrays to integer flags to match new test expectations |
| clouddrift/ragged.py | Extend unpack signature to support xarray.DataArray in parameters and return |
| CONTRIBUTING.md | Update pytest/coverage globs to use *_test.py naming |
Comments suppressed due to low confidence (2)
clouddrift/ragged.py:792
- The default of None for
rowsisn’t covered by the current type annotation. Consider usingrows: int | Iterable[int] | NoneorOptional[int | Iterable[int]].
rows: int | Iterable[int] = None,
tests/kinematics_test.py:27
- Replacing boolean literals with 1/0 may introduce unintended type mismatches when downstream code expects booleans. Consider using True/False or explicitly converting the array dtype.
[1, 1, 1, 0, 0],
tests/plotting_test.py
Outdated
| from unittest.mock import patch | ||
|
|
||
| import cartopy.crs as ccrs | ||
| import cartopy.crs as ccrs # type: ignore |
There was a problem hiding this comment.
[nitpick] Adding a brief comment explaining why the type check is ignored here could help future maintainers understand the suppressed warning.
| import cartopy.crs as ccrs # type: ignore | |
| import cartopy.crs as ccrs # type: ignore # cartopy does not provide complete type stubs |
|
There were exceptions in |
|
@KevinShuman Shall we merge? |



Fix #511 for me.
I'm using
uvto create the environment (uv sync --extra all) and myvscode/settings.jsonis:Hopefully, it works with
condatoo, but someone should confirmed.