[TAN-7698] Blocked words in items do not prevent admins from making unrelated edits#13849
Merged
jinjagit merged 3 commits intoMay 13, 2026
Conversation
Collaborator
|
…revent-status-change
jamesspeake
approved these changes
May 13, 2026
Contributor
jamesspeake
left a comment
There was a problem hiding this comment.
Looks a good solution to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix
BlockingProfanity#verify_profanitynow scans only attributes that this request actually changed (viaActiveModel::Dirty), and for*_multilocattributes only the locales whose value differs from the previously-persisted one.ideas_update_spec.rbandcomments_spec.rb; existing create-time andextended_blockinguser-update coverage still passes.Not covered
useUpdateIdeaand its admin callers don't pattern-match error: 'includes_banned_words', so when the check legitimately should fire (e.g. an admin edits a body and introduces a flagged word) the 422 is swallowed and no message is shown. Maybe worth a follow-up.Changelog
Fixed