TAN-7709-a11y/fix-confusing-spacing-css-disabled#13799
Merged
amirabayoumi merged 1 commit intoMay 13, 2026
Merged
Conversation
amirabayoumi
changed the title
Contributor
|
Been swamped, hadn't gotten to this yet. Okay if I review this on Wednesday morning? I'm off tomorrow. if urgent, I can review retrospectively after merge |
Contributor
Author
|
@EdwinKato It is totally fine on Wednesday, take your time |
EdwinKato
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conditionally render gradient overlay to prevent empty space when CSS disabled
Previously, the gradient overlay used
display="none"which still rendered the image element in the DOM. When CSS was disabled, this created unwanted empty spaceNow the gradient only renders when hideTextOverflow is true and completely removing it from the DOM when not needed.
Changelog
For translators