TAN-7690 Incorrect aria attribute on date picker

[luucvanderzee]

@EdwinKato see here for a description: https://www.notion.so/govocal/Incorrect-ARIA-use-in-date-picker-span-2929663b7b2680b29a3df2c2f76d289a

I removed the aria-expanded attribute from all Tippy tooltips. I did this for 2 reasons:

1. Tippy wraps a span around the trigger (the thing that you click for the tooltip to appear, in this example a button) and puts the aria attribute on the span wrapper. But according to the reviewers, this is wrong and the attribute should always be on the trigger (button).
2. The value never changes- i.e. aria-expanded should become true when the thing is expanded I assume? But it never does.

So I figured we should probably remove it? But not fully sure so wanted to check with you first.

Changelog

Changed

• Removed aria attribute from tippy tooltip, and move it to trigger (button) instead

[notion-workspace]

Incorrect ARIA use in date picker span

[EdwinKato]

@luucvanderzee I think this is already fixed in master. I tried replicating it but i don't see it anymore. Tested here

[EdwinKato]

It was fixed in this pull request so we can close this and move the ticket to done

[luucvanderzee]

@EdwinKato in the ticket, they explicitly say that the attribute should not be on the span, but instead should be on the button: https://www.notion.so/govocal/Incorrect-ARIA-use-in-date-picker-span-2929663b7b2680b29a3df2c2f76d289a

Move the aria-expanded attribute from the span to the button element.

Also, should aria-expanded not become true once the tooltip is expanded? See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-expanded

[EdwinKato]

Been swamped, haven't taken another look yet. Okay if I review this on Wednesday morning? I'm off tomorrow. if urgent, I can review retrospectively after merge

[luucvanderzee]

No problem, not urgent at all 👍