feat: better self-rate-limit handling#9335
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a protocol-aware rate-limiting backoff mechanism for unknown block synchronization. It adds the UnknownBlockRateLimitedError class and updates BlockInputSync to handle retries using specific backoff timestamps. Additionally, SelfRateLimiter and UnknownBlockPeerBalancer were refactored to track and respect these limits per peer and protocol. Feedback suggests refactoring getNextRateLimitRetryAt to separate cleanup side effects from the query logic for better maintainability.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
AI Assistance Disclosure