feat: add beacon_blocks_by_head reqresp#9331
Open
wemeetagain wants to merge 3 commits intounstablefrom
Open
Conversation
wemeetagain
commented
May 6, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the BeaconBlocksByHead request-response protocol, which allows peers to request a sequence of blocks starting from a specific root and traversing backwards through parent roots. The changes include the definition of the new protocol, implementation of the onBeaconBlocksByHead handler with validation and rate limiting, and the addition of corresponding network interface methods. Unit tests have been added to verify the handler's behavior across fork boundaries and its adherence to request limits. I have no feedback to provide.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
reviewed
May 7, 2026
Contributor
twoeths
left a comment
There was a problem hiding this comment.
looks good to me, I dropped some minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
beacon_blocks_by_headReqResp ethereum/consensus-specs#5181Description
AI Assistance Disclosure