Aes arrow support#69
Merged
Merged
Conversation
Allow geom_swim_arrow() to accept mapped x positions instead of always deriving the arrow neck from xend. setup_data() now detects when x is mapped and preserves provided x/xend; when x is not mapped it preserves previous behavior by setting x = xend and extending xend by arrow_neck_length (with the same default heuristic). Added x = NA to default_aes, refactored draw_panel() for clarity while preserving scale-driven and parameter-driven arrow styling, and improved roxygen docs and examples to explain both mapping modes and arrow_neck_length behavior. Minor formatting and comment cleanups only.
Add a unit test and documentation note for using mapped aesthetics with geom_swim_arrow. The new test verifies that x/xend and arrow can be provided via aes() and used with scale_arrow_discrete(), and the vignette was updated to document that x and xend may be mapped for dynamic arrow neck lengths. Tests' PDF output was updated as a binary change.
linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to call
x+xendto define arrow neck length instead of relying on a static parameter viaarrow_neck_length.