Cast form status fields to integer to avoid haven error#235
Merged
ezraporter merged 2 commits intomainfrom Nov 4, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the fix described in #232 (comment) to cast
form_status_completefields tointegerto avoid failures whenraw_or_label = "haven"and the REDCap project returns data from the API where an entire*_completecolumn isNA.#234 describes an instance in which this can occur. We were already assuming these fields were integer type when applying factor levels so this change just ensures that explicitly.
Proposed Changes
List changes below in bullet format:
*_completevariables tointegerinmulti_choice_to_labels()multi_choice_to_labels()succeeds whenraw_or_label = "haven"and the data contains a*_completevariable that is fullyNAIssue Addressed
closes #232
PR Checklist
Before submitting this PR, please check and verify below that the submission meets the below criteria:
.RDS) updated underinst/testdata/create_test_data.Rusethis::use_version()Code Review
This section to be used by the reviewer and developers during Code Review after PR submission
Code Review Checklist