common UPDATE allow custom error message#1806
Merged
Merged
Conversation
np_reply_err_sr checks the "(path" pattern in the error log to allocate the path variable. When a RPC creates a custom error message without the pattern, the path variable is not allocated. netopeer2-server can crash. In this patch, don't use the path variable if not allocated and produce a default error on cleanup.
michalvasko
approved these changes
May 22, 2026
Member
|
Thanks, looks okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
np_reply_err_sr checks the "(path" pattern in the error log to allocate the path variable.
When a RPC creates a custom error message without the pattern, the path variable is not allocated.
netopeer2-server can crash.
In this patch, don't use the path variable if not allocated and produce a default error on cleanup.
This is the case with some error messages from libyang-python.
BR