Conversation
calexiou
commented
Apr 22, 2026
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Confidence score: 3/5
- There is a concrete regression risk in
scripts/install-minio.sh:wgetmay keep an existingminiofile instead of replacing it, so installs can silently use a stale binary. - Because this is a high-severity, high-confidence behavior issue (7/10, 9/10) in an install path, it can directly affect user-facing setup/update reliability.
- Pay close attention to
scripts/install-minio.sh- ensure the download step reliably replaces old binaries to avoid stale versions.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/install-minio.sh">
<violation number="1" location="scripts/install-minio.sh:5">
P1: This download can leave a stale `minio` binary in place because `wget` does not overwrite existing files by default.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Switch
miniofrom a vendored Git LFS binary to build-time downloads. This reduces repo size, simplifies the Dockerfile, and ensures AAS uses a 2022 gateway-compatible build for S3 gateway support.scripts/resources/minioand its LFS rule in.gitattributes.minio; it runsscripts/install-minio.sh.scripts/install-minio.sh: forTARGETBUILD=aas, download the 2022miniofrom Budibase CloudFront andchmod +x; otherwise fetch arch-specific binaries from official release URLs.Written for commit 795b1bd. Summary will update on new commits.