Skip to content

Feat/pdb improvements on helm#18601

Merged
calexiou merged 4 commits intomasterfrom
feat/pdb-improvements-on-helm
Apr 23, 2026
Merged

Feat/pdb improvements on helm#18601
calexiou merged 4 commits intomasterfrom
feat/pdb-improvements-on-helm

Conversation

@calexiou
Copy link
Copy Markdown
Contributor

@calexiou calexiou commented Apr 22, 2026


Summary by cubic

Add per-service PodDisruptionBudgets and optional readiness gates to the Helm chart to improve safe rollouts and load balancer draining. Updated defaults for replicas and graceful shutdown reduce downtime during node drains and deployments.

  • New Features

    • PDBs enabled by default with global podDisruptionBudget.minAvailable (override per-service via services.<name>.pdb.minAvailable).
    • PDBs added for proxy, apps, worker, automationWorkers, and litellm.
    • Optional readinessGates for proxy, apps, worker, automationWorkers, and litellm (e.g. target-health.elbv2.k8s.aws/my-tgb).
    • More graceful shutdown: terminationGracePeriodSeconds: 75, preStop sleep: 40s.
    • Default replicaCount set to 2 for proxy, apps, worker, automationWorkers, and litellm.
    • Comprehensive Helm tests for PDBs, readiness gates, and defaults.
  • Migration

    • Running single-replica? Either set podDisruptionBudget.enabled: false, or set per-service pdb.minAvailable: 0, or keep PDBs and scale replicas to 2.
    • The longer preStop/grace period slows rollouts slightly; ensure your controller timeouts accommodate this.

Written for commit 4e99510. Summary will update on new commits.

@calexiou calexiou changed the title Feat/pdb improvements on helm WIP: Feat/pdb improvements on helm Apr 22, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 12 files

Confidence score: 3/5

  • There is a concrete behavior risk in charts/budibase/templates/pdb.yaml: using coalesce for minAvailable can ignore an explicit 0, causing service-level PDB overrides to silently fall back to the global value.
  • Given the medium severity (6/10) and high confidence (9/10), this is more than a cosmetic issue and could change disruption-budget behavior in user-facing deployments.
  • Pay close attention to charts/budibase/templates/pdb.yaml - explicit minAvailable: 0 needs to be preserved so override intent is not lost.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="charts/budibase/templates/pdb.yaml">

<violation number="1" location="charts/budibase/templates/pdb.yaml:9">
P2: Using `coalesce` for `minAvailable` ignores explicit `0` overrides, so per-service PDB settings can silently fall back to the global value.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread charts/budibase/templates/pdb.yaml
@calexiou calexiou self-assigned this Apr 22, 2026
@calexiou calexiou changed the title WIP: Feat/pdb improvements on helm Feat/pdb improvements on helm Apr 22, 2026
@calexiou calexiou merged commit 8fdf776 into master Apr 23, 2026
42 checks passed
@calexiou calexiou deleted the feat/pdb-improvements-on-helm branch April 23, 2026 08:51
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants