Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 12 files
Confidence score: 3/5
- There is a concrete behavior risk in
charts/budibase/templates/pdb.yaml: usingcoalesceforminAvailablecan ignore an explicit0, causing service-level PDB overrides to silently fall back to the global value. - Given the medium severity (6/10) and high confidence (9/10), this is more than a cosmetic issue and could change disruption-budget behavior in user-facing deployments.
- Pay close attention to
charts/budibase/templates/pdb.yaml- explicitminAvailable: 0needs to be preserved so override intent is not lost.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="charts/budibase/templates/pdb.yaml">
<violation number="1" location="charts/budibase/templates/pdb.yaml:9">
P2: Using `coalesce` for `minAvailable` ignores explicit `0` overrides, so per-service PDB settings can silently fall back to the global value.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
PClmnt
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add per-service PodDisruptionBudgets and optional readiness gates to the Helm chart to improve safe rollouts and load balancer draining. Updated defaults for replicas and graceful shutdown reduce downtime during node drains and deployments.
New Features
podDisruptionBudget.minAvailable(override per-service viaservices.<name>.pdb.minAvailable).automationWorkers, andlitellm.readinessGatesfor proxy, apps, worker,automationWorkers, andlitellm(e.g.target-health.elbv2.k8s.aws/my-tgb).terminationGracePeriodSeconds: 75,preStopsleep: 40s.replicaCountset to 2 for proxy, apps, worker,automationWorkers, andlitellm.Migration
podDisruptionBudget.enabled: false, or set per-servicepdb.minAvailable: 0, or keep PDBs and scale replicas to 2.Written for commit 4e99510. Summary will update on new commits.