Skip to content

fix: teams requires re-linking more than it should#18593

Open
Dakuan wants to merge 9 commits intomasterfrom
18446-knowledge-workshop-investigate-teams-auth-persistence-repeated-relinking
Open

fix: teams requires re-linking more than it should#18593
Dakuan wants to merge 9 commits intomasterfrom
18446-knowledge-workshop-investigate-teams-auth-persistence-repeated-relinking

Conversation

@Dakuan
Copy link
Copy Markdown
Contributor

@Dakuan Dakuan commented Apr 21, 2026

Description

  • fixes an issue where teams would unlink itself
  • adds extra logging to make it easier to fix if it happens some more (i suspect other data structures will unlink when they should not)

@Dakuan Dakuan changed the title fix: add test that should fail fix: teams requires re-linkinging more than it should Apr 21, 2026
@Dakuan Dakuan changed the title fix: teams requires re-linkinging more than it should fix: teams requires re-linking more than it should Apr 21, 2026
@Dakuan Dakuan force-pushed the 18446-knowledge-workshop-investigate-teams-auth-persistence-repeated-relinking branch from 302e239 to ee10e2d Compare April 21, 2026 15:47
@Dakuan Dakuan force-pushed the 18446-knowledge-workshop-investigate-teams-auth-persistence-repeated-relinking branch from ee10e2d to d509bcd Compare April 21, 2026 15:48
@github-actions github-actions Bot added size/m and removed size/s labels Apr 24, 2026
@Dakuan
Copy link
Copy Markdown
Contributor Author

Dakuan commented Apr 24, 2026

@cubic-dev-ai

@cubic-dev-ai
Copy link
Copy Markdown
Contributor

cubic-dev-ai Bot commented Apr 24, 2026

@cubic-dev-ai

@Dakuan I have started the AI code review. It will take a few minutes to complete.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@Dakuan Dakuan marked this pull request as ready for review April 24, 2026 12:50
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant