Merged
Conversation
* created conversion strategy interface * added libreoffice and pandoc strategies * added a new converter class * added driver and drivers array to config * added contructor to strategies * wip conversion validator * wip * created InputFileNotFoundException * added a driver override method * created cleanup service * implemented cleanup strategy * wip * finished FileHandler * removed ConversionService * added todo for LibreOffice strategy
* wip * updated disk in libreoffice strategy * minor refactor and test for Format Registry * added OdtFormat to registry * added RtfFormat to the registry * added TxtFormat to registry * added HtmlFormat to registry * added XmlFormat to registry * added XlsxFormat to registry * added OdsFormat to registry * added XlsFormat to registry * added PptxFormat to registry * added PptFormat to registry * added OdpFormat to registry * added SvgFormat to registry * added JpgFormat to registry * added PngFormat to registry * added BmpFormat to registry * added TiffFormat to registry * updated strategies * undo composer changes
* removed unused ConversionValidator * added tests for cleanup * added basic tests for Filename class * added test for docx * Add sample docs for integration tests * debug mimetype * updated libre_office path for gitgub action test * workflow test * workflow test * test workflow * test workflow * tes workflow * updated libre office path * added fileinfo to php in workflow * added logs for mime detection * testing logging * testing workflow * testing workflow * adedd lfs files to workflow * removed log statements * added tests for Doc and BMP formats * added CSV tests * added html, jpg and odp tests * wip * updated ods smaple file * added detect mimetype from zip method * odt and png tests added * added ppt conversion test * added pptx and rtf tests * added svg tests * added tiff tests * addd txt tests * added xls test * added xlsx test * added xml test * added libre office path to laravel env environment * updated libreoffice path * debug bmp in workflow * updated mime types to array * set libre office path * added image/x-ms-bmp to bmp mimetypes
* wip mark implementation * wip markdown * added imagick strategy + minor refactor * refactored conversion result * updated tests and added imagick to github workflow * refactored cleanup service * updated readme + added webp and gif support * added tests for gif and webp * adding gif and webp sample files * updated cleanup class tests * updated readme and testcase * added potrace install to the workflow * updated test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant updates to the
Doxswappackage, focusing on expanding format support, enhancing the workflow, and updating documentation. Below is a summary of the most important changes:Expanded Format Support:
.gitattributesfor Git LFS.README.mdto reflect new image format support and detailed conversion tracking. [1] [2]Workflow Enhancements:
.github/workflows/main.ymlto include Git LFS setup, additional PHP extensions, and new steps for listing files and installing Potrace for BMP to SVG conversion.Configuration and Documentation Updates:
README.mdto include installation instructions for new dependencies (ImageMagick, Potrace) and detailed usage examples. [1] [2]config/config.phpto include new file naming strategies and conversion drivers.Codebase Updates:
ConversionStrategyandConvertibleFormatto support the new conversion functionalities. [1] [2]Miscellaneous:
composer.jsonto change the version and update dependencies. [1] [2]These changes enhance the
Doxswappackage by adding support for more file formats, improving the workflow, and providing clearer documentation and configuration options.