feat: add reusable qwen3 reference conditioning#156
Draft
gaelic-ghost wants to merge 3 commits intoBlaizzy:mainfrom
Draft
feat: add reusable qwen3 reference conditioning#156gaelic-ghost wants to merge 3 commits intoBlaizzy:mainfrom
gaelic-ghost wants to merge 3 commits intoBlaizzy:mainfrom
Conversation
Why: - external callers can use the public Qwen3TTSReferenceConditioning type in generate APIs - without a public initializer, that type could not actually be constructed outside the module Verification: - swift build - swift test - xcodebuild build-for-testing -scheme MLXAudio-Package -destination 'platform=macOS' MACOSX_DEPLOYMENT_TARGET=14.0 CODE_SIGNING_ALLOWED=NO - xcodebuild test-without-building -scheme MLXAudio-Package -destination 'platform=macOS' -skip-testing:'MLXAudioTests/SmokeTests' -parallel-testing-enabled NO CODE_SIGNING_ALLOWED=NO
lucasnewman
reviewed
Apr 15, 2026
| } | ||
| } | ||
|
|
||
| private func resolveVoiceDesignGenerationSettings( |
Collaborator
There was a problem hiding this comment.
I'm not sure I get the idea of this struct -- it's seems the same as GenerateParameters with the language from the conditioning, but we already have the default generate params to resolve the sampling defaults, so it seems like we're getting a net code / complexity increase by introducing this additional type at the call sites.
Collaborator
|
@gaelic-ghost Can you resolve the conflicts with the main branch and see the comment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Qwen3TTSReferenceConditioningsurface for consumer-managed clone/reference preparationconditioning:refAudio/refTextpath routed through the same underlying implementationWhy
Presently, when the same
refAudioandrefTextare reused across multiple generations, the model repeats the same conditioning work each time. This change adds a surface for consumers to do that work once, and receive a type containing the conditioning to store and reuse as they wish, without introducing instance-local cache state.Notes
This is the branch I referenced in #149, restored as a clean branch on top of current
main.