[fix][client] Fix deserialized BatchMessageIdImpl acknowledgment failure#15
Open
BewareMyPower wants to merge 8 commits intomasterfrom
Open
[fix][client] Fix deserialized BatchMessageIdImpl acknowledgment failure#15BewareMyPower wants to merge 8 commits intomasterfrom
BewareMyPower wants to merge 8 commits intomasterfrom
Conversation
4 tasks
BewareMyPower
force-pushed
the
bewaremypower/message-id-deserialization-fix
branch
from
329e6ac to
ba52f1e
Compare
Fixes apache#19030 ### Motivation When a `BatchMessageIdImpl` is created from a deserialization, the `BatchMessageAcker` object cannot be shared by all instances in the same batch, which leads to an acknowledgment failure when batch index ACK is disabled (by default). ### Modifications Maintain a map from the `(ledger id, entry id)` pair to the `BatchMessageAcker` in `ConsumerImpl`. If the `BatchMessageIdImpl` doesn't carry a valid `BatchMessageAcker`, create and cache a `BatchMessageAcker` instance and remove it when all messages in the batch are acknowledged. It requires a change in `MessageIdImpl#fromByteArray` that a `BatchMessageAckerDisabled` will be created to indicate there is no shared acker. To avoid making code more complicated, this patch refactors the existing code that many logics about consumer are moved from the ACK tracker to the consumer. It also removes the `AckType` parameter when acknowledging a list of messages.
BewareMyPower
force-pushed
the
bewaremypower/message-id-deserialization-fix
branch
from
ba52f1e to
1eb278d
Compare
Co-authored-by: tison <[email protected]>
|
The pr had no activity for 30 days, mark with Stale label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache#19030
Motivation
When a
BatchMessageIdImplis created from a deserialization, theBatchMessageAckerobject cannot be shared by all instances in the same batch, which leads to an acknowledgment failure when batch index ACK is disabled (by default).Modifications
Maintain a map from the
(ledger id, entry id)pair to theBatchMessageAckerinConsumerImpl. If theBatchMessageIdImpldoesn't carry a validBatchMessageAcker, create and cache aBatchMessageAckerinstance and remove it when all messages in the batch are acknowledged.It requires a change in
MessageIdImpl#fromByteArraythat aBatchMessageAckerDisabledwill be created to indicate there is no shared acker.To avoid making code more complicated, this patch refactors the existing code that many logics about consumer are moved from the ACK tracker to the consumer. It also removes the
AckTypeparameter when acknowledging a list of messages.