Skip to content

feat: update golden sample app to Angular 21 [WEO-15]#620

Open
tcorral wants to merge 17 commits intomainfrom
feat/weo-15-upgrade-to-angular-21
Open

feat: update golden sample app to Angular 21 [WEO-15]#620
tcorral wants to merge 17 commits intomainfrom
feat/weo-15-upgrade-to-angular-21

Conversation

@tcorral
Copy link
Copy Markdown
Collaborator

@tcorral tcorral commented Mar 27, 2026

No description provided.

@tcorral tcorral marked this pull request as ready for review April 20, 2026 09:24
shell: bash
env:
NODE_AUTH_TOKEN: ${{ inputs.npm-auth-token }}
NODE_EMAIL: ${{ inputs.npm-email }}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since npm-email is not in use, you should also remove it from the input list as it mentions it as required.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you see that is required, @rahul-chavda ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at line 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants