fix update timestep print message#6846
Open
JustinRayAngus wants to merge 2 commits intoBLAST-WarpX:developmentfrom
Open
fix update timestep print message#6846JustinRayAngus wants to merge 2 commits intoBLAST-WarpX:developmentfrom
JustinRayAngus wants to merge 2 commits intoBLAST-WarpX:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a print issue introduced in PR #6840. When
ApplyDtLimiters()is called, the updated time step is printed using:amrex::Print() << Utils::TextMsg::Info("updating timestep to dt = " + std::to_string(dt[0]));I find that the print looks like:
--- INFO : updating timestep to dt = 0.000000.This PR instead uses
Which looks like
--- INFO : updating timestep to DT = 1.000000e-12It was also commented in PR #6840 that
ApplyDtLimiters()is not applied at step 0, resulting in the time step set by the CFL for light waves. This PR also adds the call toApplyDtLimiters()at step = 0.