avoid NaN in maxParticleVelocity()#6831
Merged
JustinRayAngus merged 3 commits intoBLAST-WarpX:developmentfrom May 5, 2026
Merged
avoid NaN in maxParticleVelocity()#6831JustinRayAngus merged 3 commits intoBLAST-WarpX:developmentfrom
JustinRayAngus merged 3 commits intoBLAST-WarpX:developmentfrom
Conversation
JustinRayAngus
changed the title
JustinRayAngus
merged commit e6db7c9
into
BLAST-WarpX:development
47 of 48 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix a random job hang that I've experienced recently on Tuolumne.
I've tracked the hang down to
mypc->maxParticleVelocity(), which is called fromUpdateDtFromParticleSpeeds()when using dynamic time stepping. The code there does not guard against boxes with zero particles, which eventually results in taking the sqrt of an uninitialized value resulting in localmax_v = nan. This PR avoids NaN values.With this fix, I have not yet observed any random job hanging.