binary collision energy conservation, sort by weight#6825
Merged
dpgrote merged 7 commits intoBLAST-WarpX:developmentfrom May 1, 2026
Merged
Conversation
Contributor
|
This looks good Dave, but I think we want sorting to be an option. It can be expensive for large number of particles, and it's not always needed. For example, you may only have different weights for different species. In that case there is no need to sort. |
JustinRayAngus
approved these changes
May 1, 2026
Contributor
JustinRayAngus
left a comment
JustinRayAngus
left a comment
There was a problem hiding this comment.
Looks good. Thanks!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the binary collisions when moment conservation is turned on, this PR adds code to sort the particles by weight before applying the energy conservation correction. This sorting shifts more of the correction to the heavier particles - the correction will have a smaller effect on their momenta. Also, since the heavier particles can absorb or give off more energy, this sorting will typically require adjusting fewer particles to apply the correction.
A quick timing test shows that with the sorting, the simulation time is a few percent faster, presumably because of the fewer particles being required for the correction versus the extra time for the sorting.