Further cleanup in binary collision moment conservation#6824
Merged
dpgrote merged 1 commit intoBLAST-WarpX:developmentfrom Apr 29, 2026
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR that does a small cleanup of the moment conservation with binary collisions, and handles the special case for inter-species collisions where each species has one particle in the cell. With one particle in the cell, the energy conservation cannot be applied since it is done pairwise. So, when the option is turned on, the collision in this case will be reverted, with a preference for momentum and energy conservation over a likely numerically inaccurate collision.