Add checks for MR and subcycling requirements#6755
Open
oshapoval wants to merge 3 commits intoBLAST-WarpX:developmentfrom
Open
Add checks for MR and subcycling requirements#6755oshapoval wants to merge 3 commits intoBLAST-WarpX:developmentfrom
oshapoval wants to merge 3 commits intoBLAST-WarpX:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging and testing issues with MR and subcycling, I noticed that there is currently no abort message when the user sets a refinement ratio other than 2 while using the MR subcycling algorithm.
As of now MR combined with subcycling algorithm is only implemented for:
• one level of refinement,
• a refinement ratio of 2 in all directions.
This PR adds a validation check that triggers an abort if the configuration is invalid.