Spin push in ChrPlasmaLens#1452
Merged
Merged
Conversation
cemitch99
added
component: elements
Merging this PR will not alter performance
Performance Changes
Comparing 
Footnotes
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ax3l
reviewed
May 11, 2026
Comment on lines
+218
to
+219
| T_Real const Bx = -m_g * ( y + m_taper * x * y ) * gamma_ref * m_beta; | ||
| T_Real const By = m_g * ( x + m_taper*0.5_prt * (powi<2>(x) + powi<2>(y)) ) * gamma_ref * m_beta; |
ax3l
reviewed
May 11, 2026
- bug: cmath missing - style: declaration misleading (used)
- ChrPlasmaLens - TaperedPL
ax3l
reviewed
May 11, 2026
| ids=["madx", "si"], | ||
| ) | ||
| def test_ChrPlasmaLens(sim, unit, k): | ||
| kwargs = {} if sim.spin else PIPE_KWARGS |
ax3l
reviewed
May 11, 2026
| @pytest.mark.parametrize("sim", [True, False], indirect=True, ids=["spin", "nospin"]) | ||
| @pytest.mark.parametrize(("unit", "k"), [(0, 1.0 / 0.5), (1, 6.0)], ids=["madx", "si"]) | ||
| def test_TaperedPL(sim, unit, k): | ||
| kwargs = {} if sim.spin else ALIGNMENT_KWARGS |
ax3l
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the spin push in a
ChrPlasmaLenselement.TaperedPLThe benchmark step relies on PR#1433.