ci: test alew/conditional test#4353
Draft
QxBytes wants to merge 37 commits intoalew/test-branch-conditional-testfrom
Draft
ci: test alew/conditional test#4353QxBytes wants to merge 37 commits intoalew/test-branch-conditional-testfrom
QxBytes wants to merge 37 commits intoalew/test-branch-conditional-testfrom
Conversation
* Initial plan * fix: remediate zizmor security alerts in GitHub Actions workflows - Fix template-injection in stale.yaml: use env var for outputs expansion - Pin actions/stale@main to commit SHA in stale.yaml - Add permissions: contents: read to golangci.yaml, baseimages.yaml, crdgen.yaml, cyclonus-netpol-extended-nightly-test.yaml, and cyclonus-netpol-test.yaml workflows - Pin all unpinned action references to full commit SHAs across all affected workflows (checkout, setup-go, upload-artifact, download-artifact, golangci-lint-action, kind-action, codeql-action) - Add persist-credentials: false to all actions/checkout steps to fix artipacked credential persistence issues - Add cache: false to actions/setup-go in codeql.yaml and cyclonus-netpol-test.yaml to fix cache-poisoning issues Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/ba4b31c5-fc6d-4d60-8f40-194f5808f2cc Co-authored-by: jpayne3506 <[email protected]> * fix: restore accidentally removed setup-go fields in govulncheck.yaml Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/ba4b31c5-fc6d-4d60-8f40-194f5808f2cc Co-authored-by: jpayne3506 <[email protected]> * fix: add cooldown configuration to all dependabot update entries (zizmor dependabot-cooldown) Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/6e92c448-6ee5-468c-9a5f-881798e58aed Co-authored-by: jpayne3506 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jpayne3506 <[email protected]>
* Initial plan * Add GitHub Actions workflow for unit tests (convert from AZP) Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/65c859ae-cffd-4891-a71d-15c17aa8a992 Co-authored-by: jpayne3506 <[email protected]> * chore: manual updates for go version + security * wrap fd-redirect/tee block with set +e/+o pipefail to preserve exit-code propagation Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/22d6fdb8-35a0-4791-a1bc-8ea11a3b1464 Co-authored-by: jpayne3506 <[email protected]> * test: linux runner * test: use window cmd shell * test: 22.04 * ci: add required npm pkgs * fix: CNS UT ordering issue * ci: add merge group and concurrency group * chore: address comments * Initial plan Co-authored-by: rbtr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jpayne3506 <[email protected]> Co-authored-by: jpayne3506 <[email protected]> Co-authored-by: rbtr <[email protected]>
QxBytes
force-pushed
the
alew/conditional-test
branch
from
97eaa3e to
2738558
Compare
QxBytes
force-pushed
the
alew/conditional-test
branch
from
2738558 to
49376fb
Compare
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| (exit "$test_exit") | ||
|
|
||
| - name: Upload Linux Coverage | ||
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7 |
| go tool cover -func=windows-coverage.out | ||
|
|
||
| - name: Upload Windows Coverage | ||
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7 |
| mv linux-coverage.xml coverage/ | ||
|
|
||
| - name: Upload Coverage Report | ||
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7 |
* feat: distill contribution and review history into agent skills Signed-off-by: Evan Baker <[email protected]> * feat: Creates agent instructions Signed-off-by: Evan Baker <[email protected]> * Update .github/copilot-instructions.md Co-authored-by: Copilot <[email protected]> Signed-off-by: Evan Baker <[email protected]> * address feedback Signed-off-by: Evan Baker <[email protected]> --------- Signed-off-by: Evan Baker <[email protected]> Co-authored-by: Copilot <[email protected]>
* initial draft * hardcode for testing * increase time to download container image * move upstream k8s to step template * add null characters to succeed with issues * fix matching-- an empty directory now counts as the pattern not being found and exiting with an error * add whitelisted log for cni framework bug to only warn for cniv1 e2e * add literal \x00 in addition to the existing null character search pattern for all windows scenarios * duplicate stages for testing * make cniv1 logs collect even during warning * increase timeout for windows again from 6m to 12m * add "hcnOpenNetwork failed in Win32: The network was not found" to error whitelist in byocni windows since c:\k\kubeclusterconfig.json is set to none instead of azure, the windows cleanup script doesn't run. so if there is a populated azure-vnet.json, it doesn't clean up on restart. if the hns network is somehow deleted or never created, azure-vnet.exe thinks an hns network exists because it sees the network in the azure-vnet.json but when it tries to open it, it errors out-- this is unrecoverable * try patching kubeclusterconfig cni name so cleanup script runs on byocni windows nodes * move patch to windows overlay tests so it benefits from restart when it was its own task, if it failed, it would never be retried (500 error) if it resides in windows overlay tests, if that test failed it would restart and hopefully retry setting the cni name to azure (after the restart node) * print out matches * collect windows node reset logs * patch windows node reset so we see the logs * make windowsnodereset patch idempotent * attempt unmarsahl of hns network into single object if array fails if there is only a single hns network, the bytes will give you an an hns network object, not an array of hns network objects, causing unmarshal to fail. to fix this, we try unmarshal into a single object if we cannot unmarshal into an array the second network is the "ext" network which I do not believe has impact on datapath-- pod -> node, pod -> pod connectivity are fine * add skip to basic tests k8s * collect more info on failure * add patch for restart scenario too * improve collect info script * add comments (noop) * remove hardcoded testing * fix spelling (noop) * remove testing base repo * increase konnectivity agent timeout from 3m to 6m * add cilium logs to collect linux logs * add retries to install cilium this pipeline does not test cilium itself, just the components that interact with it
QxBytes
force-pushed
the
alew/conditional-test
branch
from
dc46a5e to
582e532
Compare
QxBytes
force-pushed
the
alew/conditional-test
branch
from
582e532 to
6c7050c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: