set node selectors in pod yaml for scale tests.#4325
set node selectors in pod yaml for scale tests.#4325sivakami-projects wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds explicit node selection constraints to the scale-test pod manifest so scale test pods can be scheduled onto the intended OS / workload-type nodes in long-running SwiftV2 clusters.
Changes:
- Extend
PodDatawith aWorkloadTypefield for template rendering. - Pass
OS(derived) andWorkloadTypeinto the scale test pod creation path. - Update the scale-test pod YAML template to include
nodeSelectorforkubernetes.io/osand optionalworkload-type.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/integration/swiftv2/longRunningCluster/datapath.go | Adds WorkloadType to PodData so templates can optionally select nodes by workload label. |
| test/integration/swiftv2/longRunningCluster/datapath_scale_test.go | Computes/passes podOS and WorkloadType into pod creation for scale tests. |
| test/integration/manifests/swiftv2/long-running-cluster/pod-with-device-plugin.yaml | Adds nodeSelector for OS and optional workload type to constrain scheduling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@sivakami-projects Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
2 similar comments
|
@sivakami-projects Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@sivakami-projects Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
Agent-Logs-Url: https://github.com/Azure/azure-container-networking/sessions/2c28e357-d96d-4aa9-8590-18cc7c43ed14 Co-authored-by: sivakami-projects <[email protected]>
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Reason for Change:
Add OS and workload type node selectors in the pod yaml used in scale tests.
Issue Fixed:
Requirements:
Notes: