Skip to content

set node selectors in pod yaml for scale tests.#4325

Open
sivakami-projects wants to merge 2 commits intomasterfrom
sivakami/scale-test-investigation
Open

set node selectors in pod yaml for scale tests.#4325
sivakami-projects wants to merge 2 commits intomasterfrom
sivakami/scale-test-investigation

Conversation

@sivakami-projects
Copy link
Copy Markdown
Contributor

@sivakami-projects sivakami-projects commented Apr 8, 2026

Reason for Change:

Add OS and workload type node selectors in the pod yaml used in scale tests.

Issue Fixed:

Requirements:

Notes:

@sivakami-projects sivakami-projects marked this pull request as ready for review April 8, 2026 15:53
@sivakami-projects sivakami-projects requested a review from a team as a code owner April 8, 2026 15:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit node selection constraints to the scale-test pod manifest so scale test pods can be scheduled onto the intended OS / workload-type nodes in long-running SwiftV2 clusters.

Changes:

  • Extend PodData with a WorkloadType field for template rendering.
  • Pass OS (derived) and WorkloadType into the scale test pod creation path.
  • Update the scale-test pod YAML template to include nodeSelector for kubernetes.io/os and optional workload-type.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test/integration/swiftv2/longRunningCluster/datapath.go Adds WorkloadType to PodData so templates can optionally select nodes by workload label.
test/integration/swiftv2/longRunningCluster/datapath_scale_test.go Computes/passes podOS and WorkloadType into pod creation for scale tests.
test/integration/manifests/swiftv2/long-running-cluster/pod-with-device-plugin.yaml Adds nodeSelector for OS and optional workload type to constrain scheduling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/integration/swiftv2/longRunningCluster/datapath_scale_test.go
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

@sivakami-projects Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c79c6e5c-0b91-4aae-ad6c-84448f0af17d

Sorry for the inconvenience!

2 similar comments
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

@sivakami-projects Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c79c6e5c-0b91-4aae-ad6c-84448f0af17d

Sorry for the inconvenience!

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

@sivakami-projects Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c79c6e5c-0b91-4aae-ad6c-84448f0af17d

Sorry for the inconvenience!

@sivakami-projects
Copy link
Copy Markdown
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants