Fix false positive for 'co-founded' in PronounVerbAgreement linter#3009
Draft
nmurrell07 wants to merge 1 commit intoAutomattic:masterfrom
Draft
Fix false positive for 'co-founded' in PronounVerbAgreement linter#3009nmurrell07 wants to merge 1 commit intoAutomattic:masterfrom
nmurrell07 wants to merge 1 commit intoAutomattic:masterfrom
Conversation
The word 'co' was incorrectly marked with the pronoun annotation (I), causing the PronounVerbAgreement linter to flag words like 'co-founded'. This removes the incorrect pronoun marker from the dictionary entry. Fixes Automattic#3006
Collaborator
|
The meanings of the dictionary annotation flags are in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect dictionary tag for "co" by removing an erroneous
Imarker from its part-of-speech annotation.The Bug
The word
cowas incorrectly tagged with anIflag in the dictionary definition:This extra tag likely causes incorrect grammatical analysis or spell-check behavior for this word (e.g., treating it as a different part of speech than intended).
What This Change Does
Removes the
Icharacter from the dictionary entry's tag string. The remaining tags (~NS(dE) appear to be the correct annotation for "co" in Harper's linguistic format.Note: Without access to the original issue thread (API returned 404), I cannot confirm exactly what semantic meaning the
Iflag represents or which specific bug this resolves. Based on common dictionary tag conventions, it may indicate an incorrect part-of-speech classification.Verification
To verify this fix:
Limitations
Iflag without documentation or maintainer inputIf this change doesn't resolve the intended bug, please share more details about what behavior was expected vs. observed.