Add IPolicyProvider interface for enum-based policy management with HTTP client support#2657
Closed
Add IPolicyProvider interface for enum-based policy management with HTTP client support#2657
Conversation
Co-authored-by: nejaco-MSFT <125219867+nejaco-MSFT@users.noreply.github.com>
Co-authored-by: nejaco-MSFT <125219867+nejaco-MSFT@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Create IPolicyProvider for resilient HttpClient calls
Add IPolicyProvider interface for enum-based policy management with HTTP client support
Jun 20, 2025
Member
|
I don't understand where this has come from or why, so I'm closing it as there has been zero discussion in advance. It looks to be replicating functionality that already exists downstream from dotnet/extensions. |
Copilot stopped work on behalf of
martincostello due to an error
June 20, 2025 05:41
Member
I was wondering the same thing. It isn't clear who initiated the Copilot request, either. Agreed that this should be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a new
IPolicyProviderinterface that provides pre-configured Polly resilience pipelines based on enum identifiers, specifically designed for HTTP client scenarios with timeout and retry capabilities.Features Added
Core Components
IPolicyProvider: Interface for retrieving policies by enum identifierPolicyType: Enum defining available policy types (currentlyHttpClient)PolicyProviderOptions: Configuration class with validation attributesDefaultPolicyProvider: Main implementation with automatic configuration reload capabilityHTTP Client Policy
The HTTP client policy combines timeout and retry strategies:
TimeoutRejectedException,TaskCanceledException,OperationCanceledExceptionConfiguration Management
IOptionsMonitorfor automatic configuration reloadingDependency Injection
Usage Example
Key Benefits
Implementation Details
ResiliencePipelinearchitectureFiles Added
src/Polly.Extensions/PolicyProvider/IPolicyProvider.cssrc/Polly.Extensions/PolicyProvider/PolicyType.cssrc/Polly.Extensions/PolicyProvider/PolicyProviderOptions.cssrc/Polly.Extensions/PolicyProvider/DefaultPolicyProvider.cssrc/Polly.Extensions/PolicyProvider/PolicyProviderServiceCollectionExtensions.cssrc/Polly.Extensions/PolicyProvider/README.mdtest/Polly.Extensions.Tests/PolicyProvider/PolicyProviderTests.csThis implementation addresses the need for a simplified, enum-based approach to policy management while maintaining the full power and flexibility of Polly's resilience patterns.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.