[LLM] feat: Implement 'About' Section via Bottom Tab & License Collection #157
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| package com.anysoftkeyboard.janus.app.ui | ||
|
|
||
| import android.content.Context | ||
| import android.content.Intent | ||
| import android.net.Uri | ||
| import androidx.compose.foundation.BorderStroke | ||
| import androidx.compose.foundation.clickable | ||
| import androidx.compose.foundation.layout.Column | ||
| import androidx.compose.foundation.layout.Row | ||
| import androidx.compose.foundation.layout.Spacer | ||
| import androidx.compose.foundation.layout.fillMaxSize | ||
| import androidx.compose.foundation.layout.fillMaxWidth | ||
| import androidx.compose.foundation.layout.height | ||
| import androidx.compose.foundation.layout.padding | ||
| import androidx.compose.foundation.layout.size | ||
| import androidx.compose.foundation.rememberScrollState | ||
| import androidx.compose.foundation.verticalScroll | ||
| import androidx.compose.material.icons.Icons | ||
| import androidx.compose.material.icons.automirrored.filled.ArrowForward | ||
| import androidx.compose.material3.ButtonDefaults | ||
| import androidx.compose.material3.Icon | ||
| import androidx.compose.material3.MaterialTheme | ||
| import androidx.compose.material3.OutlinedButton | ||
| import androidx.compose.material3.Scaffold | ||
| import androidx.compose.material3.Text | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.platform.LocalContext | ||
| import androidx.compose.ui.res.painterResource | ||
| import androidx.compose.ui.res.stringResource | ||
| import androidx.compose.ui.text.style.TextAlign | ||
| import androidx.compose.ui.unit.dp | ||
| import com.anysoftkeyboard.janus.app.BuildConfig | ||
| import com.anysoftkeyboard.janus.app.R | ||
| import com.google.android.gms.oss.licenses.OssLicensesMenuActivity | ||
|
|
||
| /** | ||
| * About screen displaying application information, explanation of the unique translation mechanism | ||
| * (The Colophon), links to GitHub repository and issue tracker, and the open-source licenses | ||
| * attribution page. | ||
| */ | ||
| @Composable | ||
| fun AboutScreen(modifier: Modifier = Modifier) { | ||
| val context = LocalContext.current | ||
| val scrollState = rememberScrollState() | ||
|
|
||
| Scaffold(modifier = modifier) { paddingValues -> | ||
| Column( | ||
| modifier = | ||
| Modifier.fillMaxSize() | ||
| .verticalScroll(scrollState) | ||
| .padding(paddingValues) | ||
| .padding(horizontal = 24.dp, vertical = 24.dp), | ||
| horizontalAlignment = Alignment.CenterHorizontally, | ||
| ) { | ||
| // 1. Header | ||
| Icon( | ||
|
Member
There was a problem hiding this comment. [Maintenance] The Icon component uses a tint on a mipmap resource (ic_launcher_foreground). This matches the monochromatic design goal but is fragile for bitmaps. Consider using a dedicated vector or setting tint to Color.Unspecified. |
||
| painter = painterResource(R.mipmap.ic_launcher_foreground), | ||
| contentDescription = null, | ||
| modifier = Modifier.size(96.dp), | ||
| tint = MaterialTheme.colorScheme.primary, | ||
| ) | ||
| Spacer(modifier = Modifier.height(12.dp)) | ||
| Text( | ||
| text = stringResource(R.string.about_title), | ||
| style = MaterialTheme.typography.headlineMedium, | ||
| color = MaterialTheme.colorScheme.onSurface, | ||
| ) | ||
| Spacer(modifier = Modifier.height(4.dp)) | ||
| Text( | ||
| text = stringResource(R.string.about_version, BuildConfig.VERSION_NAME), | ||
| style = MaterialTheme.typography.labelLarge, | ||
| color = MaterialTheme.colorScheme.secondary, | ||
| ) | ||
| Spacer(modifier = Modifier.height(28.dp)) | ||
|
|
||
| // 2. Abstract | ||
| Text( | ||
| text = stringResource(R.string.about_abstract), | ||
| style = MaterialTheme.typography.bodyLarge, | ||
| color = MaterialTheme.colorScheme.onSurface, | ||
| textAlign = TextAlign.Center, | ||
| ) | ||
| Spacer(modifier = Modifier.height(28.dp)) | ||
|
|
||
| // 3. Methodology | ||
| Text( | ||
| text = stringResource(R.string.about_methodology_title), | ||
| style = MaterialTheme.typography.titleMedium, | ||
| color = MaterialTheme.colorScheme.primary, | ||
| modifier = Modifier.align(Alignment.Start), | ||
| ) | ||
| Spacer(modifier = Modifier.height(8.dp)) | ||
| Text( | ||
| text = stringResource(R.string.about_methodology_text), | ||
| style = MaterialTheme.typography.bodyMedium, | ||
| color = MaterialTheme.colorScheme.onSurface, | ||
| modifier = Modifier.align(Alignment.Start), | ||
| ) | ||
| Spacer(modifier = Modifier.height(28.dp)) | ||
|
|
||
| // 4. References | ||
| ReferenceLinkRow( | ||
| label = stringResource(R.string.about_link_source_code), | ||
| url = "https://github.com/AnySoftKeyboard/janus", | ||
| context = context, | ||
| ) | ||
| Spacer(modifier = Modifier.height(4.dp)) | ||
| ReferenceLinkRow( | ||
| label = stringResource(R.string.about_link_issue_tracker), | ||
| url = "https://github.com/AnySoftKeyboard/janus/issues", | ||
| context = context, | ||
| ) | ||
| Spacer(modifier = Modifier.height(28.dp)) | ||
|
|
||
| // 5. Attributions | ||
| OutlinedButton( | ||
| onClick = { context.startActivity(Intent(context, OssLicensesMenuActivity::class.java)) }, | ||
| colors = | ||
| ButtonDefaults.outlinedButtonColors( | ||
| contentColor = MaterialTheme.colorScheme.secondary | ||
| ), | ||
| border = BorderStroke(1.dp, MaterialTheme.colorScheme.secondary), | ||
| modifier = Modifier.fillMaxWidth(), | ||
| ) { | ||
| Text( | ||
|
Member
There was a problem hiding this comment. [Risk] The startActivity call for OssLicensesMenuActivity is not protected. Any failure to resolve the class or launch the intent will result in a crash. This should be wrapped in a try-catch block to handle ActivityNotFoundException. |
||
| text = stringResource(R.string.about_button_licenses), | ||
| style = MaterialTheme.typography.labelLarge, | ||
| ) | ||
| } | ||
| Spacer(modifier = Modifier.height(16.dp)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| private fun ReferenceLinkRow( | ||
| label: String, | ||
| url: String, | ||
| context: Context, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Row( | ||
| modifier = | ||
| modifier | ||
| .fillMaxWidth() | ||
| .clickable { | ||
| val intent = Intent(Intent.ACTION_VIEW, Uri.parse(url)) | ||
| context.startActivity(intent) | ||
| } | ||
|
Member
There was a problem hiding this comment. [Risk] Launching an external browser using ACTION_VIEW can throw an ActivityNotFoundException on devices without a browser. This call must be protected to ensure system stability. |
||
| .padding(vertical = 12.dp), | ||
| verticalAlignment = Alignment.CenterVertically, | ||
| ) { | ||
| Text( | ||
| text = label, | ||
| style = MaterialTheme.typography.bodyLarge, | ||
| color = MaterialTheme.colorScheme.primary, | ||
| modifier = Modifier.weight(1f), | ||
| ) | ||
| Icon( | ||
| imageVector = Icons.AutoMirrored.Filled.ArrowForward, | ||
| contentDescription = null, | ||
| tint = MaterialTheme.colorScheme.secondary, | ||
| modifier = Modifier.size(20.dp), | ||
| ) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Observation] The AboutScreen uses a nested Scaffold. Ensure that it doesn't cause conflicting inset handling with the Scaffold in JanusApp. It appears safe here as the inner Scaffold has no bars.