Skip to content

Add toggle to match inline title color to H1 color#316

Open
iwa wants to merge 4 commits intoAnubisNekhet:mainfrom
iwa:feat/toggle-match-h1-inline-title-colors
Open

Add toggle to match inline title color to H1 color#316
iwa wants to merge 4 commits intoAnubisNekhet:mainfrom
iwa:feat/toggle-match-h1-inline-title-colors

Conversation

@iwa
Copy link
Copy Markdown
Contributor

@iwa iwa commented Oct 20, 2024

fixes #264

i feel that is a little but great addition, avoiding people headaches to deal with css snippets

@AnubisNekhet
Copy link
Copy Markdown
Owner

Forgive me for asking, but wouldn't applying every h1 customization to inline title make more sense? I can't see any reason not to add other values as well, unless there's a reason not to.

@iwa
Copy link
Copy Markdown
Contributor Author

iwa commented Oct 29, 2024

mmh that's actually a good point, I think I'll check out what other popular themes are doing so we can have an idea of what users are expecting

@notnotnescap
Copy link
Copy Markdown
Contributor

notnotnescap commented Nov 12, 2024

I think it should be a separate setting. It could go above the H1 dropdown and would have the same settings as each header (font family, size, weight, height, color and maybe even an option for a divider)

Screenshot 2024-11-12 at 14 44 32

Anyways, this is a really nice addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Inline title color not consistent with h1 color

3 participants