fix(ci): avoid pending required checks on skipped PR workflows#497
Open
wax911 wants to merge 1 commit into
Open
fix(ci): avoid pending required checks on skipped PR workflows#497wax911 wants to merge 1 commit into
wax911 wants to merge 1 commit into
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AniTrend Pull Request
Description
.github/workflows/android-ci.ymlrun on every PR todevelopdorny/paths-filter, then skip irrelevant jobs at the job level instead of skipping the whole workflow at the trigger levelWrapper ValidationandUnit Testsso branch protection can accept skipped checks instead of leaving them pending.github/workflows/python-ci.ymlas a push-only workflow for the emoji generator so PR validation comes from a single workflow path.github/workflows/python-cd.ymlin the Python workflow scope so dependency automation changes stay coveredThis is aimed at unblocking automerge/merge for PRs that only touch the Python dependency-management workflow or other non-Android areas, where required Android checks were previously left pending by workflow-level path filtering.
Types of changes
Verification
git diff --check -- .github/workflows/android-ci.yml .github/workflows/python-ci.yml✅ruby -e 'require \"yaml\"; [\".github/workflows/android-ci.yml\", \".github/workflows/python-ci.yml\"].each { |f| YAML.load_file(f); puts \"ok #{f}\" }'✅\n-cd scripts/emoji_generator && poetry run pytest -v✅ (9 passed)\n-./gradlew spotlessCheck --console=plain❌ blocked by an existing AGP 9 /org.jetbrains.kotlin.androidplugin failure inapp/build.gradle.kts\n-./gradlew emojify:preTest emojify:test emojify:postTest --console=plain❌ blocked by the same existingapp/build.gradle.ktsfailure\n