Skip to content

fix(ci): avoid pending required checks on skipped PR workflows#497

Open
wax911 wants to merge 1 commit into
developfrom
bugfix/pr-ci-skipped-checks
Open

fix(ci): avoid pending required checks on skipped PR workflows#497
wax911 wants to merge 1 commit into
developfrom
bugfix/pr-ci-skipped-checks

Conversation

@wax911
Copy link
Copy Markdown
Member

@wax911 wax911 commented May 18, 2026

AniTrend Pull Request

Description

  • move the merge-facing PR checks into an always-triggered workflow surface by letting .github/workflows/android-ci.yml run on every PR to develop
  • detect Android vs Python changes inside the workflow with dorny/paths-filter, then skip irrelevant jobs at the job level instead of skipping the whole workflow at the trigger level
  • preserve the required job names Wrapper Validation and Unit Tests so branch protection can accept skipped checks instead of leaving them pending
  • keep .github/workflows/python-ci.yml as a push-only workflow for the emoji generator so PR validation comes from a single workflow path
  • include .github/workflows/python-cd.yml in the Python workflow scope so dependency automation changes stay covered

This is aimed at unblocking automerge/merge for PRs that only touch the Python dependency-management workflow or other non-Android areas, where required Android checks were previously left pending by workflow-level path filtering.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (Improves existing functionality)

Verification

  • git diff --check -- .github/workflows/android-ci.yml .github/workflows/python-ci.yml
  • ruby -e 'require \"yaml\"; [\".github/workflows/android-ci.yml\", \".github/workflows/python-ci.yml\"].each { |f| YAML.load_file(f); puts \"ok #{f}\" }' ✅\n- cd scripts/emoji_generator && poetry run pytest -v ✅ (9 passed)\n- ./gradlew spotlessCheck --console=plain ❌ blocked by an existing AGP 9 / org.jetbrains.kotlin.android plugin failure in app/build.gradle.kts\n- ./gradlew emojify:preTest emojify:test emojify:postTest --console=plain ❌ blocked by the same existing app/build.gradle.kts failure\n

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants