Fix for tempDir, "non-ubiquitous" files, and crash on empty conflict#89
Merged
AndreasSko merged 7 commits intomasterfrom Jun 16, 2025
Merged
Fix for tempDir, "non-ubiquitous" files, and crash on empty conflict#89AndreasSko merged 7 commits intomasterfrom
AndreasSko merged 7 commits intomasterfrom
Conversation
Some users recently started to report getting the following error message: > The file couldn’t be opened because you don’t have permission to view it. During debugging I noticed that on iOS 18.4 files stored on OneDrive don't seem to be considered ubiquitous items, which triggers that issue. I haven't seen the problem with iOS 18.5, but just to be sure we are now also supporting downloading files that are not ubiquitous. Also used the change to improve capturing erros for Sentry.
Sometimes the app would crash if - for some reason(?) - there was an empty conflict or one of the sides was empty. With this change, we show a proper error message instead of panicing.
As explained in AndreasSko/go-library-merger#166 users reported issues with the temporary directory when importing backups. With this commit we explicitly set the temporary directory that is directly provided by the fileManager.
If there is nothing to clean up, then that is fine. It is not an issue we need to worry about, so also no need to capture it for Sentry.
This should help with debugging errors.
AndreasSko
force-pushed
the
fix_tmpdir
branch
2 times, most recently
from
7bba146 to
7ef3df5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues:
Potential fix for temporary dir issue
As explained in AndreasSko/go-library-merger#166 users reported issues with the temporary directory when importing backups.
With this commit, we explicitly set the temporary directory that is directly provided by the fileManager.
Fix crash on empty conflict
Sometimes the app would crash if - for some reason(?) - there was an empty conflict or one of the sides was empty. With this change, we show a proper error message instead of panicking.
Support downloading "non-ubiquitous" files(?)
Some users recently started to report getting the following error message:
During debugging, I noticed that on iOS 18.4 files stored on OneDrive don't seem to be considered ubiquitous items, which triggers that issue. I haven't seen the problem with iOS 18.5, but just to be sure we are now also supporting downloading files that are not ubiquitous.
Also used the change to improve capturing errors for Sentry.
Other changes
Sentry: Add breadcrumbs to JWLMController
This should help with debugging errors by giving more context to an issue.