Skip to content

GPU/TPC: Use qTot as marker for HIP clusters instead of qMax#15481

Merged
davidrohr merged 3 commits into
AliceO2Group:devfrom
fweig:hip-compression
Jun 4, 2026
Merged

GPU/TPC: Use qTot as marker for HIP clusters instead of qMax#15481
davidrohr merged 3 commits into
AliceO2Group:devfrom
fweig:hip-compression

Conversation

@fweig
Copy link
Copy Markdown
Contributor

@fweig fweig commented Jun 3, 2026

No description provided.

@davidrohr
Copy link
Copy Markdown
Collaborator

I did 3 tests:

  • Compared this version with hipTailFilter disabled to the O2 version before the hipTailFilter code in deterministic mode: 100% identical results
  • Checked tracking efficiencies and ncl/track in this version with hipTailFilter enabled and disabled. Shows only marginal differences. And tiny differences are expected since the cluster will slightly differ.
  • Run sync and async reco in the standalone benchmark and compared the saturated clusters, and they are identical. So they fully survive the track model compression / truncation.

What I did not do yet is to recompile O2 and create CTFs with it, but I am still traveling with only my laptop.

I also checked the dedx code, and it uses qtot directly, not the getter, but it also uses only 16bit int storage. So this needs to be rethought.

In any case, the cluster writing for saturated signals seems to be correct now, and the version is 100% backward-compatible.

@davidrohr
Copy link
Copy Markdown
Collaborator

errors unrelated, merging

@davidrohr davidrohr merged commit 8e372de into AliceO2Group:dev Jun 4, 2026
10 of 12 checks passed
ehellbar pushed a commit that referenced this pull request Jun 4, 2026
* Use qTot as marker for HIP clusters instead of qMax

* Adjust handling of saturated qTot

* Adjust qTot limit in cluster statistics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants