GPU/TPC: Use qTot as marker for HIP clusters instead of qMax#15481
Merged
Conversation
davidrohr
approved these changes
Jun 4, 2026
Collaborator
|
I did 3 tests:
What I did not do yet is to recompile O2 and create CTFs with it, but I am still traveling with only my laptop. I also checked the dedx code, and it uses qtot directly, not the getter, but it also uses only 16bit int storage. So this needs to be rethought. In any case, the cluster writing for saturated signals seems to be correct now, and the version is 100% backward-compatible. |
Collaborator
|
errors unrelated, merging |
ehellbar
pushed a commit
that referenced
this pull request
Jun 4, 2026
* Use qTot as marker for HIP clusters instead of qMax * Adjust handling of saturated qTot * Adjust qTot limit in cluster statistics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.