feat(settings): add Protect Recycle Bin setting#104
Merged
Conversation
The Recycle Bin is a safety net for accidental deletions and should not be emptied silently during routine cleaning. This adds a new `protectRecycleBin` toggle (default: true) under Cleaning Preferences that skips the Recycle Bin in manual cleans, the dedicated Cleaner page, and scheduled runs. Users can opt out in Settings if they want Kudu to clean it. Existing installs pick up the safe default via deepMerge. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deepMergeAddresses user feedback that Kudu silently empties the Recycle Bin, removing the user's safety net for recovering accidentally deleted files.
Test plan
cleaner:recycleBinincluded — verify it is skipped when toggle is onnpm run validate:rulespassesnpx tsc --noEmitproduces no new errors🤖 Generated with Claude Code