Update to Angular v21#37
Merged
Merged
Conversation
Closed
5221524 to
1b11943
Compare
1b11943 to
a7220b7
Compare
Co-authored-by: Copilot <copilot@github.com>
af639b1 to
f5d0dea
Compare
| } | ||
|
|
||
| @HostListener('window:scroll', ['$event']) | ||
| @HostListener('window:scroll') |
Collaborator
There was a problem hiding this comment.
maybe in the future we can use host instead of @HostListener as that's the recommended approach :)
TerranceKhumalo-absa
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to Angular 21 and Node.js 22, modernizes build tooling, and improves configuration for testing and markdown sanitization. The main focus is on dependency upgrades, workflow improvements, and compatibility updates.
Dependency and Compatibility Upgrades:
cps-ui-kit,ngx-markdown, andmarked) to versions compatible with Angular 21 in bothpackage.jsonandprojects/cps-mdoc-viewer/package.json. [1] [2]zone.jsand other dev dependencies (e.g.,jest,@angular-builders/jest,@angular-eslint/*) to latest compatible versions.GitHub Actions Workflow Modernization:
actions/checkout@v5,actions/setup-node@v5, and Node.js v22.x; replaced manual cache steps with the built-incache: 'npm'option. [1] [2] [3] [4]Testing and Build Configuration:
"zoneless": falseto the Jest test builder options inangular.jsonto ensure compatibility with Angular 21's testing requirements. [1] [2]provideZoneChangeDetection()for compatibility with Angular 21's zone handling.Markdown and Security Handling:
SANITIZEinjection token inprojects/cps-mdoc-viewer/src/lib/lib.provider.ts, reflecting changes inngx-markdownv21. [1] [2]Other Improvements:
omit-lockfile-registry-resolved=trueto.npmrcfor improved lockfile handling.@HostListenerfor scroll handling.