Skip to content

Add option to fill ghost cells in average_cellcenter_to_face#5345

Merged
WeiqunZhang merged 6 commits intoAMReX-Codes:developmentfrom
BenDavisonPetch:avg_cc_to_fc_growcells
Apr 20, 2026
Merged

Add option to fill ghost cells in average_cellcenter_to_face#5345
WeiqunZhang merged 6 commits intoAMReX-Codes:developmentfrom
BenDavisonPetch:avg_cc_to_fc_growcells

Conversation

@BenDavisonPetch
Copy link
Copy Markdown
Contributor

@BenDavisonPetch BenDavisonPetch commented Apr 17, 2026

Summary

Adds an optional parameter ngrow to average_cellcenter_to_face and two new overloads that take an array of AMREX_SPACEDIM IntVects. average_cellcenter_to_face fills this many ghost cells in the face-centred MultiFabs.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@BenDavisonPetch BenDavisonPetch marked this pull request as draft April 17, 2026 16:01
@BenDavisonPetch BenDavisonPetch marked this pull request as ready for review April 17, 2026 16:15
Comment thread Src/Base/AMReX_MultiFabUtil.cpp Outdated
@WeiqunZhang
Copy link
Copy Markdown
Member

Also, let's not worry about the versions using Vector<MultiFab*>. We have that for backward compatibility, otherwise we would have removed them. The Array version is better because it has explicit size.

@BenDavisonPetch
Copy link
Copy Markdown
Contributor Author

Also, let's not worry about the versions using Vector<MultiFab*>. We have that for backward compatibility, otherwise we would have removed them. The Array version is better because it has explicit size.

Makes sense; I've removed the new Vector<MultiFab*> overload.

@WeiqunZhang WeiqunZhang merged commit 515ed5e into AMReX-Codes:development Apr 20, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants