Update valkey repository URL to OCI format#298
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughBumped the Helm chart version and changed the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.Add a .trivyignore file to your project to customize which findings Trivy reports. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
charts/n8n/Chart.yaml (2)
36-38:⚠️ Potential issue | 🟡 Minor
artifacthub.io/changesannotation is stale — still describes the previous ingress/pathType change, not this valkey repository update.The
changesentry should be updated to reflect the dependency source change introduced by this PR.✏️ Suggested update
artifacthub.io/changes: | - - kind: changed - description: "Changed the ingress logic to allow different types of pathType in place of the hardcoded 'pathType: Prefix'" + - kind: changed + description: "Updated valkey dependency repository to OCI format"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@charts/n8n/Chart.yaml` around lines 36 - 38, The artifacthub.io/changes annotation in Chart.yaml is stale; update the "changes" entry under artifacthub.io/changes to describe the dependency source change introduced by this PR (the valkey repository update) instead of the old ingress/pathType note—locate the artifacthub.io/changes block and replace the current description lines with a brief entry mentioning the dependency source update (e.g., "Changed dependency source: updated valkey repository"), keeping the same YAML structure and list formatting.
3-3:⚠️ Potential issue | 🟠 MajorChart.lock must be regenerated and chart version must be bumped after the dependency repository change.
The
valkeyrepository has been changed fromhttps://valkey.io/valkey-helm/tooci://ghcr.io/valkey-io/valkey-helm/valkey, butChart.lockstill references the old HTTPS URL. This mismatch will causehelm dependency updateto resolve dependencies inconsistently. RegenerateChart.lockby runninghelm dependency update charts/n8n, and bump the chart version inChart.yaml(currently 2.0.1) to signal this breaking change to downstream consumers.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@charts/n8n/Chart.yaml` at line 3, Regenerate the Helm dependency lock and bump the chart version: update Chart.yaml's version (currently 2.0.1 — increment it, e.g., 2.0.2) and run "helm dependency update charts/n8n" to refresh Chart.lock so the valkey dependency uses the new OCI URL (oci://ghcr.io/valkey-io/valkey-helm/valkey) instead of the old https://valkey.io/valkey-helm/; commit the updated Chart.yaml and regenerated Chart.lock.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/n8n/Chart.yaml`:
- Around line 28-31: The dependency entry with name: valkey has an incorrect OCI
repository URL that includes the chart name; update the repository field from
oci://ghcr.io/valkey-io/valkey-helm/valkey to the parent OCI registry
oci://ghcr.io/valkey-io/valkey-helm so Helm will append /valkey:0.8.1 itself,
and then verify that the specified version (version: 0.8.1) actually exists in
that GHCR namespace (update version if necessary).
---
Outside diff comments:
In `@charts/n8n/Chart.yaml`:
- Around line 36-38: The artifacthub.io/changes annotation in Chart.yaml is
stale; update the "changes" entry under artifacthub.io/changes to describe the
dependency source change introduced by this PR (the valkey repository update)
instead of the old ingress/pathType note—locate the artifacthub.io/changes block
and replace the current description lines with a brief entry mentioning the
dependency source update (e.g., "Changed dependency source: updated valkey
repository"), keeping the same YAML structure and list formatting.
- Line 3: Regenerate the Helm dependency lock and bump the chart version: update
Chart.yaml's version (currently 2.0.1 — increment it, e.g., 2.0.2) and run "helm
dependency update charts/n8n" to refresh Chart.lock so the valkey dependency
uses the new OCI URL (oci://ghcr.io/valkey-io/valkey-helm/valkey) instead of the
old https://valkey.io/valkey-helm/; commit the updated Chart.yaml and
regenerated Chart.lock.
3deep5me
force-pushed
the
patch-1
branch
2 times, most recently
from
142bbb6 to
acbf2d9
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Signed-off-by: 3deep5me <[email protected]>
|
should be fine now. |
2 participants
What this PR does / why we need it
Update to valkey repo to OCI format to be future proof.
Special notes for your reviewer
It makes it easier to pull the dep. chart over a proxy harbor.
Checklist
Version and Documentation
Chart.yamlfollowing semantic versioningChart.yamlif applicableartifacthub.io/changessection updated inChart.yaml(see ArtifactHub annotation reference)README.mdTesting and Validation
ah lintlocally without errorsct lint --chart-dirs charts/n8n --charts charts/n8n --validate-maintainers=false/examplesdirectorySummary by CodeRabbit