test(video-to-text): align source assertion with P0-2 sanitization (unblocks main CI)#410
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 28 minutes and 0 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates video-to-text skill tests to match the post-#408 contract where returned source URLs are sanitized (query string stripped) to prevent signed-URL secret leakage.
Changes:
- Update
result["source"]assertions in three video-to-text tool test suites to expect the query-stripped URL. - Add brief comments in each test explaining the P0-2 sanitization behavior (
redact_urlstripping query strings).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/skills/tools/video_to_text_openai/test_video_to_text_openai.py | Adjusts source assertion to expect query-stripped URL for OpenAI backend. |
| tests/skills/tools/video_to_text_local/test_video_to_text_local.py | Adjusts source assertion to expect query-stripped URL for local backend. |
| tests/skills/tools/video_to_text_groq/test_video_to_text_groq.py | Adjusts source assertion to expect query-stripped URL for Groq backend. |
Summary
Unblocks main: PR #408 (P0-2 redact_url) introduced
redact_url()that strips query strings fromsourceURLs in fetch/video tools, but 3 existing tests in `tests/skills/tools/video_to_text_{groq,openai,local}/` still asserted the un-sanitized URL. They've been red on main since #408 merged.This PR updates those 3 assertions to match the new (correct) sanitized contract: `source` no longer echoes back signed-URL credentials.
Why this slipped past PR #408 CI
PR #408's pre-push verification ran `tests/unit/ tests/smoke/ tests/tools/`, missing `tests/skills/` where these regression tests live. CI on PR #408 caught it but auto-merge proceeded anyway because branch protection on main has `required_status_checks.contexts: []` — no checks are gated, so the auto-merge workflow's `gh pr merge --auto` immediately merges instead of waiting for green.
(Branch-protection / auto-merge fix to be filed as a follow-up — that's a separate concern from unblocking main.)
Test plan
🤖 Generated with Claude Code