PICARD-3249: Fix tag name autocompletion in Edit Tag dialog

The visible_tags generator expression was exhausted by addItems(),
leaving the QCompleter with no completion candidates.

Use a list comprehension instead so the data can be consumed by both
addItems() and QCompleter.

Introduced in d765211 ("Replace TAG_NAMES dict by a generator
tag_names()").

Author: zas

picard/ui/metadatabox/edittagdialog.py

@@ -202,7 +202,7 @@ def _initialize_ui(self):
     def _setup_tag_combobox(self):
         """Set up the tag name combobox with supported tags."""
         self.default_tags = self._get_supported_tags()
-        visible_tags = (tn for tn in self.default_tags if not tn.startswith("~"))  # TODO: use TagVar.is_hidden?
+        visible_tags = [tn for tn in self.default_tags if not tn.startswith("~")]  # TODO: use TagVar.is_hidden?
 
         self.ui.tag_names.addItem("")
         self.ui.tag_names.addItems(visible_tags)