Skip to content

Commit 45ed571

Browse files
authored
refactor: update CreateFilter function for header filters (#3779)
Inline headerFilterConfig to reduce function return params and reduce complexity. Remove some test functions in favour of `assert` as it's already implementing same functionality. Use `any` instead of `interface{}` when possible just for less linters suggesstions. Follow up on #3778 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
1 parent f8d418a commit 45ed571

4 files changed

Lines changed: 132 additions & 166 deletions

File tree

filters/builtin/compress_test.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414
"testing"
1515
"time"
1616

17+
"github.com/stretchr/testify/assert"
1718
"github.com/zalando/skipper/eskip"
1819
"github.com/zalando/skipper/filters"
1920
"github.com/zalando/skipper/filters/filtertest"
@@ -543,13 +544,7 @@ func TestCompress(t *testing.T) {
543544
rsp.Header.Del("Content-Type")
544545
}
545546

546-
if !compareHeaders(rsp.Header, ti.expectedHeader) {
547-
printHeader(t, ti.expectedHeader, "invalid header", "expected")
548-
printHeader(t, rsp.Header, "invalid header", "got")
549-
550-
t.Error("invalid header")
551-
return
552-
}
547+
assert.Equal(t, ti.expectedHeader, rsp.Header)
553548

554549
if ok, err := compareBody(rsp, ti.contentLength); err != nil {
555550
t.Error(err)

filters/builtin/decompress_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ func backend(t *testing.T, contentEncoding string, content io.Reader) *httptest.
3232
}
3333

3434
func decompressingProxy(t *testing.T, backendURL string) *proxytest.TestProxy {
35+
t.Helper()
3536
routes := `
3637
* -> decompress() -> "%s"
3738
`

0 commit comments

Comments
 (0)