test: better log message on failed test in TestAdmissionControl (#3810)

szuecs · web-flow · commit 154fa30a560f · 2026-01-02T17:09:36.000+01:00
test: better log message on failed test in TestAdmissionControl

Signed-off-by: Sandor Szücs &lt;sandor.szuecs@zalando.de&gt;
diff --git a/filters/shedder/admission_test.go b/filters/shedder/admission_test.go
@@ -267,10 +267,10 @@ func TestAdmissionControl(t *testing.T) {
 				t.Logf("ok: %d, fail: %d, failBackend: %d, epsilon: %d, expectedOk: %d", ok, fail, failBackend, epsilon, expectedOk)
 
 				if ti.expectedFails-epsilon > fail || fail > ti.expectedFails+epsilon {
-					t.Fatalf("Failed to get expected fails: %d != %d", ti.expectedFails, fail)
+					t.Fatalf("Failed to get expected fails: %d > %d > %d", ti.expectedFails-epsilon, fail, ti.expectedFails+epsilon)
 				}
 				if expectedOk-epsilon > ok || ok > expectedOk+epsilon {
-					t.Fatalf("Failed to get expected OKs: %d != %d", ti.expectedFails, fail)
+					t.Fatalf("Failed to get expected OKs: %d > %d > %d", expectedOk-epsilon, fail, expectedOk+epsilon)
 				}
 			})
 		})

Original file line number	Diff line number	Diff line change
`@@ -267,10 +267,10 @@ func TestAdmissionControl(t *testing.T) {`
`267`	`267`	`t.Logf("ok: %d, fail: %d, failBackend: %d, epsilon: %d, expectedOk: %d", ok, fail, failBackend, epsilon, expectedOk)`
`268`	`268`
`269`	`269`	`if ti.expectedFails-epsilon > fail \|\| fail > ti.expectedFails+epsilon {`
`270`		`- t.Fatalf("Failed to get expected fails: %d != %d", ti.expectedFails, fail)`
	`270`	`+ t.Fatalf("Failed to get expected fails: %d > %d > %d", ti.expectedFails-epsilon, fail, ti.expectedFails+epsilon)`
`271`	`271`	`}`
`272`	`272`	`if expectedOk-epsilon > ok \|\| ok > expectedOk+epsilon {`
`273`		`- t.Fatalf("Failed to get expected OKs: %d != %d", ti.expectedFails, fail)`
	`273`	`+ t.Fatalf("Failed to get expected OKs: %d > %d > %d", expectedOk-epsilon, fail, expectedOk+epsilon)`
`274`	`274`	`}`
`275`	`275`	`})`
`276`	`276`	`})`