Skip to content

Commit 51a8a66

Browse files
committed
fix: turn app <button>s into <a>s
This allows Shift / Ctrl + Clicking them to open in new tab and is overall more sensible with our `hashchange` approach. A side effect of this is that the app list items no longer change brightness on hover, which could be considered a positive side effect by some. Apparently the initial implementation of showing apps in a dialog did not have the `hashchange` handler yet, so that was probably the reason to use `<button>` instead of `<a>`: 58d8e44. The `hashchange` listener was added a few commits later: 7b294dc.
1 parent 88d71db commit 51a8a66

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

website/apps/main.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ const App = ({ app, toggleModal }) => {
2727
const subtitle = app.description.split('\n').shift();
2828

2929
return html`
30-
<button
30+
<a
3131
class="app"
32-
onClick=${() => toggleModal(app.app_id)}
32+
href="#${app.app_id}"
3333
key=${app.app_id}>
3434
<img src=${xdcget_export + "/" + app.icon_relname} loading="lazy" alt="Icon for ${app.name} app" />
3535
<div class="props ellipse">

0 commit comments

Comments
 (0)