Skip to content

Hardcoded http://localhost:8001 in universal_huggingface_deployer.py #1268

@egoran2

Description

@egoran2

What

`src/asi_build/deployment/universal_huggingface_deployer.py:402`:

api_url = f\"http://localhost:8001/pipeline/{deployment_id}\"

The "universal" deployer hardcodes a local URL with no env override. Same file is what gets used to deploy to remote CUDO/HF endpoints — but as soon as the inference service moves off the box, this URL won't reach it.

Why this matters

  • The Memgraph URL (`bolt://localhost:7687`) at least has `os.getenv("MEMGRAPH_URL", ...)` as a fallback. This call site doesn't.
  • Anyone wiring up a multi-host deploy will hit a silent "why are predictions hanging" rabbit hole.

Fix

api_base = os.environ.get(\"ASI_BUILD_PIPELINE_URL\", \"http://localhost:8001\")
api_url = f\"{api_base}/pipeline/{deployment_id}\"

And document the env var in `configs/default.yaml` and `CONTRIBUTING.md` next to the existing `MEMGRAPH_URL` docs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions