rubocop: autofix

Author: bastelfreak

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2023-08-17 21:33:46 UTC using RuboCop version 1.50.2.
+# `rubocop --auto-gen-config --no-auto-gen-timestamp`
+# using RuboCop version 1.85.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -13,12 +13,52 @@ RSpec/BeEq:
     - 'spec/unit/puppet/provider/jenkins_job/cli_spec.rb'
     - 'spec/unit/puppet/x/jenkins/provider/cli_spec.rb'
 
+# Offense count: 51
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/IncludeExamples:
+  Exclude:
+    - 'spec/acceptance/class_spec.rb'
+    - 'spec/acceptance/plugin_spec.rb'
+    - 'spec/acceptance/slave_spec.rb'
+    - 'spec/acceptance/xtypes/jenkins_job_spec.rb'
+    - 'spec/defines/jenkins_plugin_spec.rb'
+    - 'spec/unit/puppet/provider/jenkins_credentials/cli_spec.rb'
+    - 'spec/unit/puppet/provider/jenkins_job/cli_spec.rb'
+    - 'spec/unit/puppet/provider/jenkins_user/cli_spec.rb'
+    - 'spec/unit/puppet/x/jenkins/config_spec.rb'
+    - 'spec/unit/puppet/x/jenkins/provider/cli_spec.rb'
+
+# Offense count: 16
+RSpec/LeakyLocalVariable:
+  Exclude:
+    - 'spec/acceptance/slave_spec.rb'
+    - 'spec/acceptance/xtypes/jenkins_credentials_spec.rb'
+    - 'spec/classes/jenkins_slave_spec.rb'
+    - 'spec/defines/jenkins_job_present_spec.rb'
+    - 'spec/defines/jenkins_job_spec.rb'
+
 # Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: .
-# SupportedStyles: constant, string
 RSpec/VerifiedDoubleReference:
-  EnforcedStyle: string
+  Exclude:
+    - 'spec/unit/puppet/x/jenkins/provider/cli_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedClasses.
+Style/OneClassPerFile:
+  Exclude:
+    - 'lib/puppet/x/jenkins.rb'
+
+# Offense count: 8
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/SelectByKind:
+  Exclude:
+    - 'lib/puppet/type/jenkins_authorization_strategy.rb'
+    - 'lib/puppet/type/jenkins_credentials.rb'
+    - 'lib/puppet/type/jenkins_job.rb'
+    - 'lib/puppet/type/jenkins_num_executors.rb'
+    - 'lib/puppet/type/jenkins_security_realm.rb'
+    - 'lib/puppet/type/jenkins_slaveagent_port.rb'
 
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).

lib/puppet/provider/jenkins_authorization_strategy/cli.rb

@@ -40,7 +40,7 @@ def self.from_hash(info)
     args = {
       name: class_name,
       ensure: :present,
-      arguments: ctor_args
+      arguments: ctor_args,
     }
 
     # map nil -> :undef
@@ -85,8 +85,8 @@ def set_jenkins_instance(input = nil)
   def set_strategy_unsecured
     input = {
       'setAuthorizationStrategy' => {
-        'hudson.security.AuthorizationStrategy$Unsecured' => []
-      }
+        'hudson.security.AuthorizationStrategy$Unsecured' => [],
+      },
     }
     set_jenkins_instance(input)
   end

lib/puppet/provider/jenkins_credentials/cli.rb

@@ -44,7 +44,7 @@ def self.from_hash(info)
 
     params = {
       name: info['id'],
-      ensure: :present
+      ensure: :present,
     }
 
     %i[impl domain scope].each { |k| copy_key(params, info, k) }

lib/puppet/provider/jenkins_job/cli.rb

@@ -20,7 +20,7 @@ def self.instances(catalog = nil)
         name: job['name'],
         ensure: :present,
         config: job['config'],
-        enable: job['enabled']
+        enable: job['enabled'],
       )
     end
   end
@@ -80,7 +80,7 @@ def self.get_job(job, catalog = nil)
   # currently unused
   def self.job_enabled(job, catalog = nil)
     raw = clihelper(['job_enabled', job], catalog: catalog)
-    raw =~ %r{true} ? true : false
+    (raw =~ %r{true}) ? true : false
   end
   private_class_method :job_enabled
 

lib/puppet/provider/jenkins_security_realm/cli.rb

@@ -40,7 +40,7 @@ def self.from_hash(info)
     args = {
       name: class_name,
       ensure: :present,
-      arguments: ctor_args
+      arguments: ctor_args,
     }
 
     # map nil -> :undef
@@ -86,8 +86,8 @@ def set_jenkins_instance(input = nil)
   def set_security_none
     input = {
       'setSecurityRealm' => {
-        'hudson.security.SecurityRealm$None' => []
-      }
+        'hudson.security.SecurityRealm$None' => [],
+      },
     }
     set_jenkins_instance(input)
   end

lib/puppet/x/jenkins/config.rb

@@ -21,7 +21,7 @@ class UnknownConfig < ArgumentError; end
     cli_username: nil,
     cli_password: nil,
     cli_password_file: '/tmp/jenkins_credentials_for_puppet',
-    cli_password_file_exists: false
+    cli_password_file_exists: false,
   }.freeze
   CONFIG_CLASS = 'jenkins::cli::config'
   FACT_PREFIX = 'jenkins_'

lib/puppet/x/jenkins/provider/cli.rb

@@ -179,7 +179,7 @@ def self.execute_with_retry(command, options = {}, cli_pre_cmd = [])
       command(:java),
       '-jar', cli_jar,
       '-s', url,
-      '-logger', 'WARNING'
+      '-logger', 'WARNING',
     ]
 
     cli_cmd = base_cmd + [command]
@@ -244,7 +244,7 @@ def self.execute_exceptionify(cmd, options)
       'You must authenticate to access this Jenkins.',
       'anonymous is missing the Overall/Read permission',
       'anonymous is missing the Overall/RunScripts permission',
-      'anonymous is missing the Overall/Administer permission'
+      'anonymous is missing the Overall/Administer permission',
     ]
     # network errors / jenkins not ready for connections not related to
     # authenication failures
@@ -253,7 +253,7 @@ def self.execute_exceptionify(cmd, options)
       'java.net.SocketException: Connection reset',
       'java.net.ConnectException: Connection refused',
       'java.io.IOException: Failed to connect',
-      'java.io.IOException: Server returned HTTP response code: 503'
+      'java.io.IOException: Server returned HTTP response code: 503',
     ]
 
     if options.key?(:tmpfile_as_param)

lib/puppet/x/jenkins/util.rb

@@ -4,7 +4,7 @@
 
 module Puppet::X::Jenkins::Util
   def unundef(data)
-    iterate(data) { |x| x == :undef ? nil : x }
+    iterate(data) { |x| (x == :undef) ? nil : x }
   end
   module_function :unundef
 

spec/acceptance/plugin_spec.rb

@@ -12,12 +12,12 @@
     "#{PDIR}/c.txt",
     "#{PDIR}/a/foo",
     "#{PDIR}/b/bar",
-    "#{PDIR}/c/baz"
+    "#{PDIR}/c/baz",
   ].freeze
   DIRS = [
     "#{PDIR}/a",
     "#{PDIR}/b",
-    "#{PDIR}/c"
+    "#{PDIR}/c",
   ].freeze
 
   shared_examples 'has_plugin' do |plugin|

spec/classes/cli/config_spec.rb

@@ -84,7 +84,7 @@
             let(:params) do
               {
                 ssh_private_key: '/dne',
-                ssh_private_key_content: 'foo'
+                ssh_private_key_content: 'foo',
               }
             end
 
@@ -99,7 +99,7 @@
                   mode: '0400',
                   backup: false,
                   owner: nil,
-                  group: nil
+                  group: nil,
                 )
               end
 
@@ -117,7 +117,7 @@
                   mode: '0400',
                   backup: false,
                   owner: 'jenkins',
-                  group: 'jenkins'
+                  group: 'jenkins',
                 )
               end