Avoid duplicating PermitUserEnvironment

Do not add a new line if the option is already defined. This avoids
adding dupulicated lines and also make sure that the existing explicit
setting to disable PermitUserEnvironment is purged.

Closes #1953

Author: kajinamit

lib/beaker/host/unix/exec.rb

@@ -301,9 +301,7 @@ def ssh_service_restart
   def ssh_permit_user_environment
     case self['platform']
     when /amazon|debian|ubuntu|archlinux|el-|centos|fedora|redhat|oracle|scientific|opensuse|sles|solaris/
-      directory = tmpdir
-      exec(Beaker::Command.new("echo 'PermitUserEnvironment yes' | cat - /etc/ssh/sshd_config > #{directory}/sshd_config.permit"))
-      exec(Beaker::Command.new("mv #{directory}/sshd_config.permit /etc/ssh/sshd_config"))
+      exec(Beaker::Command.new("sed -e 's/^PermitUserEnvironment .*/PermitUserEnvironment yes/' -e t -e '1s/^/PermitUserEnvironment yes\\n/' /etc/ssh/sshd_config > /etc/ssh/sshd_config"))
       exec(Beaker::Command.new("echo '' >/etc/environment")) if self['platform'].include?('ubuntu-')
     when /(free|open)bsd/
       exec(Beaker::Command.new("sudo perl -pi -e 's/^#?PermitUserEnvironment no/PermitUserEnvironment yes/' /etc/ssh/sshd_config"), { :pty => true })

spec/beaker/host/unix/exec_spec.rb

@@ -79,8 +79,7 @@ def to_s
     describe '#ssh_permit_user_environment' do
       context 'When called without error' do
         let(:directory) { '/directory' }
-        let(:ssh_command) { "echo 'PermitUserEnvironment yes' | cat - /etc/ssh/sshd_config > #{directory}/sshd_config.permit" }
-        let(:ssh_move) { "mv #{directory}/sshd_config.permit /etc/ssh/sshd_config" }
+        let(:ssh_command) { "sed -i -e 's/^PermitUserEnvironment .*/PermitUserEnvironment yes/' -e t -e '1s/^/PermitUserEnvironment yes\\n/' /etc/ssh/sshd_config" }
 
         platforms = PlatformHelpers::REDHATPLATFORMS + PlatformHelpers::DEBIANPLATFORMS
 
@@ -89,7 +88,6 @@ def to_s
             opts['platform'] = platform
             expect(instance).to receive(:exec).twice
             expect(instance).to receive(:tmpdir).and_return(directory)
-            expect(Beaker::Command).to receive(:new).with(ssh_move)
             expect(Beaker::Command).to receive(:new).with(ssh_command)
             expect(instance).to receive(:ssh_service_restart)
             expect { instance.ssh_permit_user_environment }.not_to raise_error