pep8: Fixed style issues.

Author: ashcrow

setup.cfg

@@ -0,0 +1,2 @@
+[pep8]
+ignore = E402

src/victims_web/config.py

@@ -58,7 +58,7 @@
 
 # CSRF Protection
 CSRF_COOKIE_NAME = 'victimsc'
-#CSRF_COOKIE_TIMEOUT = timedelta(1)
+# CSRF_COOKIE_TIMEOUT = timedelta(1)
 CSRF_DISABLED = False
 
 # Captcha
@@ -102,8 +102,9 @@
 }
 
 # Optional settings
-## Sentry Configuration
-#SENTRY_DSN = ''
+
+# Sentry Configuration
+# SENTRY_DSN = ''
 
 # Load custom configuration if available, this will override defaults above
 CFG_KEY = 'VICTIMS_CONFIG'
@@ -124,18 +125,18 @@
 
 SESSION_COOKIE_SECURE = not DEBUG
 
-## We do not need https when debugging
+# We do not need https when debugging
 if DEBUG:
     PREFERRED_URL_SCHEME = 'http'
 else:
     PREFERRED_URL_SCHEME = 'https'
 
-## Create any required directories
+# Create any required directories
 for folder in [LOG_FOLDER, UPLOAD_FOLDER, DOWNLOAD_FOLDER, CACHE_DIR]:
     if not isdir(folder):
         makedirs(folder)
 
-## Debug Toolbar
+# Debug Toolbar
 if DEBUG:
     DEBUG_TB_HOSTS = '127.0.0.1'
     DEBUG_TB_PROFILER_ENABLED = True

src/victims_web/handlers/forms.py

@@ -202,7 +202,7 @@ class RegistrationForm(Form):
     """
     Registration Form
     """
-    username = fields.StringField('Username',  [
+    username = fields.StringField('Username', [
         validators.Regexp('^[\w\.]*$', message='Invalid Username'),
         validators.required(),
         UserName(),

src/victims_web/models.py

@@ -32,6 +32,7 @@
 
 from flask.ext.bcrypt import generate_password_hash
 from flask.ext.mongoengine import Document
+from mongoengine.base import BaseDocument
 from mongoengine import (
     StringField, DateTimeField, DictField, BooleanField, EmbeddedDocument,
     EmbeddedDocumentField, ListField, EmailField
@@ -307,7 +308,7 @@ def validkeys(self):
         return HASHING_ALGORITHMS
 
 
-class Hash(JsonifyMixin, EmbeddedDocument, ValidatedDocument):
+class Hash(JsonifyMixin, EmbeddedDocument, BaseDocument):
     """
     A hash record.
     """
@@ -464,8 +465,8 @@ def add_comment(self, comment):
         ValidatedDocument.save(self)
 
     def valid_entry(self):
-        if (not self.group
-                or len(self.group.strip()) == 0):
+        if (not self.group or
+                len(self.group.strip()) == 0):
             self.add_comment('[auto] no group specified')
             return False
         if len(self.cves) == 0:

src/victims_web/plugin/downloader.py

@@ -41,7 +41,7 @@ class DownloadException(Exception):
 
 
 def download(url, target, async=False, close_target=False, quiet=True):
-    ### download file to target (target is a file-like object)
+    # download file to target (target is a file-like object)
     if async:
         _pool.submit(url, target)
     else:

src/victims_web/plugin/github.py

@@ -48,7 +48,7 @@ def _rest(self, service, endpoint, **kwargs):
     def get_commits(self, **kwargs):
         return self._rest('repos', 'commits', **kwargs)
 
-    #/repos/:owner/:repo/commits/:sha
+    # /repos/:owner/:repo/commits/:sha
     def get_commit(self, sha, **kwargs):
         return self._rest('repos', 'commits/%s' % (sha), **kwargs)
 

src/victims_web/plugin/maven.py

@@ -77,9 +77,9 @@ def to_maven_snapshot_name(self, ext):
     def __eq__(self, other):
         if isinstance(other, Artifact):
             return (
-                other.group == self.group
-                and other.artifact == self.artifact
-                and other.version == self.version
+                other.group == self.group and
+                other.artifact == self.artifact and
+                other.version == self.version
             )
         else:
             return False
@@ -94,14 +94,14 @@ def is_snapshot(self):
         return self.version.find('SNAPSHOT') > 0
 
     def is_same_artifact(self, other):
-        ## need to support wildcard
+        # TODO: need to support wildcard
         group_match = True if (
-            self.group == '*'
-            or other.group == '*'
+            self.group == '*' or
+            other.group == '*'
         ) else self.group == other.group
         artif_match = True if (
-            self.artifact == '*'
-            or other.artifact == '*'
+            self.artifact == '*' or
+            other.artifact == '*'
         ) else self.artifact == other.artifact
         return group_match and artif_match
 
@@ -184,7 +184,7 @@ def download_pom(self, artifact):
         try:
             logger.info('[Checking] pom file %s' % maven_path)
             data = download_string(maven_path)
-            ## cache
+            # cache
             self.pom_cache[artifact] = data
             return data
         except DownloadException:

src/victims_web/util.py

@@ -38,7 +38,7 @@ def hash_submission(submission_id):
         config.LOGGER.debug('Submission %s not found.' % (submission_id))
         return
 
-    if not submission.entry is None:
+    if submission.entry is not None:
         submission.add_comment('Entry alread exits. Skipping hashing.')
         return