cleanup

Author: mcollovati

flow-html-components/src/test/java/com/vaadin/flow/component/html/DivTest.java

@@ -49,40 +49,4 @@ public void testHasAriaLabelIsNotImplemented() {
     public void testNonDefaultConstructor() {
         Assert.assertEquals("text", new Div("text").getText());
     }
-
-    @Test
-    public void testAddTypedCollectionOfComponents() {
-        // Test for the GitHub issue fix - should compile and work with typed collections
-        Div container = new Div();
-        
-        // Create a List<Span> (subtype of Component)
-        java.util.List<Span> typedSpans = java.util.List
-                .of(new Span("span1"), new Span("span2"), new Span("span3"));
-        
-        // This should now compile with Collection<? extends Component>
-        container.add(typedSpans);
-        
-        Assert.assertEquals(3, container.getChildren().count());
-    }
-
-    @Test
-    public void testRemoveTypedCollectionOfComponents() {
-        // Test for the GitHub issue fix - should compile and work with typed collections
-        Div container = new Div();
-        
-        Span span1 = new Span("span1");
-        Span span2 = new Span("span2");
-        Span span3 = new Span("span3");
-        
-        container.add(span1, span2, span3);
-        Assert.assertEquals(3, container.getChildren().count());
-        
-        // Create a List<Span> (subtype of Component)
-        java.util.List<Span> typedSpans = java.util.List.of(span1, span2);
-        
-        // This should now compile with Collection<? extends Component>
-        container.remove(typedSpans);
-        
-        Assert.assertEquals(1, container.getChildren().count());
-    }
 }

flow-server/src/test/java/com/vaadin/flow/component/HasComponentsTest.java

@@ -15,6 +15,8 @@
  */
 package com.vaadin.flow.component;
 
+import java.util.List;
+
 import org.junit.AfterClass;
 import org.junit.Assert;
 import org.junit.BeforeClass;
@@ -329,18 +331,15 @@ public void bindChildren_removeThrowsWhileBindingActive() {
     }
 
     @Test
-    public void addTypedCollection_allowsAddingListOfSubtypes() {
-        // Test the fix for GitHub issue - should compile and work
+    public void add_typedCollectionOfSubtypes_addsAllChildren() {
         TestComponent container = new TestComponent();
-        
-        // Create a List<TestComponent> (subtype of Component)
-        java.util.List<TestComponent> typedComponents = java.util.List
-                .of(new TestComponent("comp1"), new TestComponent("comp2"),
-                        new TestComponent("comp3"));
-        
-        // This should now compile with Collection<? extends Component>
+
+        List<TestComponent> typedComponents = List.of(
+                new TestComponent("comp1"), new TestComponent("comp2"),
+                new TestComponent("comp3"));
+
         container.add(typedComponents);
-        
+
         assertEquals(3, container.getChildren().count());
         assertEquals("comp1",
                 container.getChildren().toList().get(0).getId().orElse(null));
@@ -351,24 +350,20 @@ public void addTypedCollection_allowsAddingListOfSubtypes() {
     }
 
     @Test
-    public void removeTypedCollection_allowsRemovingListOfSubtypes() {
-        // Test the fix for GitHub issue - should compile and work
+    public void remove_typedCollectionOfSubtypes_removesMatchingChildren() {
         TestComponent container = new TestComponent();
-        
+
         TestComponent comp1 = new TestComponent("comp1");
         TestComponent comp2 = new TestComponent("comp2");
         TestComponent comp3 = new TestComponent("comp3");
-        
+
         container.add(comp1, comp2, comp3);
         assertEquals(3, container.getChildren().count());
-        
-        // Create a List<TestComponent> (subtype of Component)
-        java.util.List<TestComponent> typedComponents = java.util.List
-                .of(comp1, comp2);
-        
-        // This should now compile with Collection<? extends Component>
+
+        List<TestComponent> typedComponents = List.of(comp1, comp2);
+
         container.remove(typedComponents);
-        
+
         assertEquals(1, container.getChildren().count());
         assertEquals("comp3",
                 container.getChildren().toList().get(0).getId().orElse(null));